Use vertical resize on the textarea.

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Use vertical resize on the textarea.

Post by Dragosvr92 » Wed Sep 12, 2012 3:49 pm

When you click the textarea grabber/resizer, and move to the right side, till you get with the cursor out of the <div id="postingbox" class="panel"> div, the textarea moves together with the smilies box, out of it(the div).

To fix it, add resize: vertical; into the #message-box textarea id...

I had a similar topic about this.. viewtopic.php?f=3&t=43093
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: Use vertical resize on the textarea.

Post by Senky » Wed Sep 12, 2012 5:33 pm

+1

please, create a ticket for it. It is simple fix. As long as it will be created, I can PR patch.
And do not forget about all textarea places - PMs, UCP, ACP, ...

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Use vertical resize on the textarea.

Post by Dragosvr92 » Wed Sep 12, 2012 8:01 pm

Here is the ticket: http://tracker.phpbb.com/browse/PHPBB3-11111

Yes, you are right. It should be added on the ACP Textareas et cetera too..
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Use vertical resize on the textarea.

Post by nickvergessen » Thu Sep 13, 2012 8:39 am

Which grabber?! We use normal Textarea's and have nothing like a grabber installed?!
Member of the Development-TeamNo Support via PM

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Use vertical resize on the textarea.

Post by callumacrae » Thu Sep 13, 2012 8:43 am

nickvergessen wrote:Which grabber?! We use normal Textarea's and have nothing like a grabber installed?!
It's a browser thing.

-1, this is a browser thing, not a phpBB thing. By all means set a max-width.
Made by developers, for developers!
My blog

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Use vertical resize on the textarea.

Post by Dragosvr92 » Thu Sep 13, 2012 8:58 am

callumacrae wrote:
nickvergessen wrote:Which grabber?! We use normal Textarea's and have nothing like a grabber installed?!
It's a browser thing.

-1, this is a browser thing, not a phpBB thing. By all means set a max-width.
huh?
Its a phpbb thing also, as you open it in a browser.
If phpbb works crappy in a browser, then it shouldnt be fixed?

phpbb already has a max-width set.....

Code: Select all

#message-box textarea {
    font-family: "Trebuchet MS",Verdana,Helvetica,Arial,sans-serif;
    font-size: 1.2em;
    height: 270px;
    max-width: 100%;
    min-width: 100%;
    width: 450px;
}
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: Use vertical resize on the textarea.

Post by Senky » Thu Sep 13, 2012 9:18 am

callumacrae: I am also against your opinion. Browsers provided end-users option to resize textarea without any help from javascript. They also implemented "resize" CSS property for designers to manage their designs in the way it fits. For designers it is really important to know that some layout items will have exact width. I do not see any disadvantage in implementing it, and it gives us advantage of more stable default style (prosilver).

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Use vertical resize on the textarea.

Post by Dragosvr92 » Thu Sep 13, 2012 12:25 pm

Senky wrote:it gives us advantage of more stable default style (prosilver).
agreed...
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Use vertical resize on the textarea.

Post by callumacrae » Thu Sep 13, 2012 1:19 pm

I feel that this would be similar to deciding that we don't like the scrollbar in some browsers, and so replacing it with our own.
Made by developers, for developers!
My blog

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Use vertical resize on the textarea.

Post by Dragosvr92 » Thu Sep 13, 2012 2:12 pm

You are wrong. It is not like that at al !
At the moment, phpbb is made to only allow vertical resizing. It doesnt get resized in horizontal, unless you move the cursor/grabber out of the div i specified in my first post, and gets the smilies box out of the div, and shows it in the white body area. The resize property fixes that. Debug/test yourself and see.

Look at the attachment to see how the smilies area looks like. if you move the cursor whille pushes out of that div....
The black line is what the normal textarea size originally was before resizing...
After you resize it, and get with the cursor near the scroll bar(where the arrow is), it gets the smilies area messed up.


Listen Killer and include it .... :P
Attachments
smilies thing.png
(167.7 KiB) Downloaded 6775 times
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply