Releasing unified diffs

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Post Reply
doktornotor
Registered User
Posts: 27
Joined: Wed Dec 21, 2011 5:34 pm

Releasing unified diffs

Post by doktornotor »

Could someone please spend a couple of minutes explaining why the patchsets are not using unified diff format either by default, or why there is not an option to download the updates in that format? There are good reason why unidiff is a de-facto requirement when submitting patches to many open-source projects. This context stuff is a PITA to read and apply manually (required for more or less heavily modded boards).

Thanks. :P

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Releasing unified diffs

Post by igorw »

I'm not trying to justify the lack of published diffs, but this can be easily generated from git. You do this by diffing two tags and limiting the diff to the phpBB subdirectory. You can pipe that to a file and run the patch.

Code: Select all

git diff release-3.0.8...release-3.0.9 -- phpBB

doktornotor
Registered User
Posts: 27
Joined: Wed Dec 21, 2011 5:34 pm

Re: Releasing unified diffs

Post by doktornotor »

Well, doing something similar ATM... Was more like wondering why the unidiff format is not used instead of the context ones. Not really sure how many people end up patching files manually, however the current format sucks for that purpose and for readability as well. ;)

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Releasing unified diffs

Post by Oleg »

I think the idea is that "code changes" that we provide are targeted at people who can't read diffs. The people that can work with diffs can easily obtain them for themselves using any number of ways (e.g. diff released packages).

Edit: if we do provide diffs in context format then I have no idea why.

doktornotor
Registered User
Posts: 27
Joined: Wed Dec 21, 2011 5:34 pm

Re: Releasing unified diffs

Post by doktornotor »

Oleg wrote: Edit: if we do provide diffs in context format then I have no idea why.
Yeah, the packages called *-patch.{zip,tar.bz2} only consist of context diffs. (diff -x images -crNEB) ;)

Post Reply