Move Sid inside the ACP urls at the very end.

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Move Sid inside the ACP urls at the very end.

Post by Dragosvr92 »

Currently when you go to view a member into the admin control panel it generates the fallowing link:

Code: Select all

http://www.example.com/forums/adm/index.php?i=users&mode=overview&sid=ac87f64eb07f78892d66693753a908bc&u=1090
It would be nice if the sid could get moved at the end, like this:

Code: Select all

http://www.example.com/forums/adm/index.php?i=users&mode=overview&u=1090&sid=ac87f64eb07f78892d66693753a908bc
I am asking this because i usually need to know what the member id is, as i want to know what the id im going to delete etc is.
If i am not mistaken thesid is always added at the end of the url on the board. So in my opinion thats how it should be added into the ACP also.

Do you think i should put this into a ticket?
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Dr. Deejay
Registered User
Posts: 12
Joined: Thu Sep 22, 2011 12:19 pm

Re: Move Sid inside the ACP urls at the very end.

Post by Dr. Deejay »

I actually don't see anything wrong with the current format tbh. In my opinion it's not worth changing it.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by callumacrae »

+1 to OP
Made by developers, for developers!
My blog

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Move Sid inside the ACP urls at the very end.

Post by igorw »

I'm not against merging such a patch if someone provides one.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by Dragosvr92 »

Dr. Deejay wrote:I actually don't see anything wrong with the current format tbh. In my opinion it's not worth changing it.
Well i do. You should see more relevant data on the link. Not a useless sid. No one cares to know whats the sid number. But there are some that might care more if the member id is more easy to see, without getting over the dumb sid.

As on the board it gets displayed at the very end of the url, why should it be different in the ACP?

@Igor, thanks for agreeing with me, i would do it, but this is over my limits.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1903
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by DavidIQ »

It would just be a matter of updating the append_sid function. Shouldnt be that difficult I think (famous last words...).
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by Dragosvr92 »

DavidIQ wrote:It would just be a matter of updating the append_sid function. Shouldnt be that difficult I think (famous last words...).
Do i hear a second yes? :D
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by callumacrae »

I can have a look at this while I'm on my way home (~ an hour away), I'll have nothing better to do xD
Made by developers, for developers!
My blog

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by naderman »

DavidIQ wrote:It would just be a matter of updating the append_sid function. Shouldnt be that difficult I think (famous last words...).
Unfortunately frequently enough stuff is appended to the return value of append_sid, so all those calls to append_sid would need to be changed.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Move Sid inside the ACP urls at the very end.

Post by Danielx64 »

+1 to OP

This could give me a chance to have a go at making a patch for this.

Post Reply