Move Sid inside the ACP urls at the very end.

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by callumacrae »

*Daniel wrote:+1 to OP

This could give me a chance to have a go at making a patch for this.
Go for it!
Made by developers, for developers!
My blog

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by Dragosvr92 »

So... Did anyone messed with it?
Is it worth submitting a ticket?
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Move Sid inside the ACP urls at the very end.

Post by imkingdavid »

TheKiller wrote:So... Did anyone messed with it?
Is it worth submitting a ticket?
Any feature change/addition needs a ticket before it is merged, iirc.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by callumacrae »

imkingdavid wrote:
TheKiller wrote:So... Did anyone messed with it?
Is it worth submitting a ticket?
Any feature change/addition needs a ticket before it is merged, iirc.
This would be an improvement, but yeah it needs a ticket.

In the future, threads for minor issues like this don't need to be made - just create a ticket.
Made by developers, for developers!
My blog

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by Dragosvr92 »

callumacrae wrote:
imkingdavid wrote:
TheKiller wrote:So... Did anyone messed with it?
Is it worth submitting a ticket?
Any feature change/addition needs a ticket before it is merged, iirc.
This would be an improvement, but yeah it needs a ticket.

In the future, threads for minor issues like this don't need to be made - just create a ticket.
I said not to fill the tracker with trash.
http://tracker.phpbb.com/browse/PHPBB3-10516
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Move Sid inside the ACP urls at the very end.

Post by Danielx64 »

I'm working on it now, my issue, I don't have a git account or the guts to get all that going, can I just provide info on what edit needs to be done?

Ok I got it sorted out:

the new url look something like this:
http://localhost/phpbb3/adm/index.php?u=2&i=users&mode=overview&sid=5e22f5132839097c0e722c37eb57b4f0

What do you think?

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Move Sid inside the ACP urls at the very end.

Post by Oleg »

You don't technically need a github account, but manual edit instructions require too much developer effort to use. We ask that you at least provide changes as a diff.

If you have git but not a github account you can use git format-patch to obtain one or a series of diffs from develop/develop-olympus, and attach those to the ticket.

If you don't even have git but have diff you can store a copy of the tree you start with and obtain a diff between trees via:

diff -urN old.tree new.tree

I believe we also still provide a subversion mirror here: http://code.phpbb.com/projects/phpbb/repository. If you have subversion installed you can use it to check out the current develop (http://code.phpbb.com/projects/phpbb/re ... show/trunk) or develop-olympus (http://code.phpbb.com/projects/phpbb/re ... hpBB-3_0_0) and use svn to obtain a diff with your changes.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Move Sid inside the ACP urls at the very end.

Post by Danielx64 »

Oleg wrote:You don't technically need a github account, but manual edit instructions require too much developer effort to use. We ask that you at least provide changes as a diff.

If you have git but not a github account you can use git format-patch to obtain one or a series of diffs from develop/develop-olympus, and attach those to the ticket.

If you don't even have git but have diff you can store a copy of the tree you start with and obtain a diff between trees via:

diff -urN old.tree new.tree

I believe we also still provide a subversion mirror here: http://code.phpbb.com/projects/phpbb/repository. If you have subversion installed you can use it to check out the current develop (http://code.phpbb.com/projects/phpbb/re ... show/trunk) or develop-olympus (http://code.phpbb.com/projects/phpbb/re ... hpBB-3_0_0) and use svn to obtain a diff with your changes.
Thankyou for the info :) I'm think I got most of the url covered but there are several that I can't find, including one that has mode=sig in the URL.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Move Sid inside the ACP urls at the very end.

Post by Danielx64 »

About time, I managed to make a patch that cover some of the sid= part, there are several places that I can not figure out. I hope the patch I provide is of some help. Should I make a new ticket to have the userid the first thing when needed?

Post Reply