Including a default Favicon for fresh instalations

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
User avatar
Vinny
Style Customisations
Style Customisations
Posts: 129
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: Including a default Favicon for fresh instalations

Post by Vinny »

CyberAlien wrote:What if website already has a favicon in root directory? Having a favicon in style would overwrite it, so I think its a bad idea.
Good point :idea: , so should have an option to enable/disable the favicon.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Including a default Favicon for fresh instalations

Post by DavidIQ »

How about we disable it by not including a reference to it in the header and if you want it you can manually edit the header file and add it? ;)
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Including a default Favicon for fresh instalations

Post by Dragosvr92 »

DavidIQ wrote:How about we disable it by not including a reference to it in the header and if you want it you can manually edit the header file and add it? ;)
hahaha ....... :roll:
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Including a default Favicon for fresh instalations

Post by Dragosvr92 »

I'm back ! :mrgreen:

Why dont we just include this image:Image in the phpbb3 release?
In my opinion it is perfect for this and it represents the software. :|
Previous user: TheKiller
Avatar on Memberlist 1.0.3

BullsNet
Registered User
Posts: 22
Joined: Fri Sep 17, 2010 5:23 pm

Re: Including a default Favicon for fresh instalations

Post by BullsNet »

+1 phpBB should have one when you fresh install.

Senky
Extension Customisations
Extension Customisations
Posts: 315
Joined: Thu Jul 16, 2009 4:41 pm

Re: Including a default Favicon for fresh instalations

Post by Senky »

Well, I am certainly for. If we include it, it makes no harm (if phpBB is not in root directory, it will be ignored, if it is, it shows up). As TheKiller said, if prosilver can have phpBB logo included, why phpBB itself cannot afford adding favicon?

Next argument for is that it (in certain conditions) removes apache (or other server system) errors (usually written in logs), because no favicon means one e404 request.

But it cannot be included in <head>, for sure not!

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: Including a default Favicon for fresh instalations

Post by naderman »

I agree we should include a favicon by default. I agree though that we should only include a default favicon.ico file, and not add an element to head for it, so that site which already have a favicon.ico keep theirs.

Senky
Extension Customisations
Extension Customisations
Posts: 315
Joined: Thu Jul 16, 2009 4:41 pm

Re: Including a default Favicon for fresh instalations

Post by Senky »

So what is the final decision? Can a ticket be created?

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Including a default Favicon for fresh instalations

Post by Oleg »

Include a favicon but not call it favicon.ico?

Senky
Extension Customisations
Extension Customisations
Posts: 315
Joined: Thu Jul 16, 2009 4:41 pm

Re: Including a default Favicon for fresh instalations

Post by Senky »

No, naderman meant including favicon.ico named favicon.ico, included in root of phpBB, but do not add it into overall_header <head> tag. If favicon is not included in <head>, browser tries to load it from root of domain (eg area51.phpbb.com/favicon.ico), so if administrator changes it, it will display custom favicon, but if it does not change it, it will display phpBB's default favicon.

Post Reply