Header links...

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Header links...

Post by EXreaction »

I just thought of this today as a nice little thing that could be added to the templates by default. It would make 1 less place(and a tricky place at that with the way some people setup styles) that needs to be modified by mods that add buttons up there.

Why not add an extra thing like the profile_fields loop in before this code?

Code: Select all

<a href="{U_FAQ}"><img src="{T_THEME_PATH}/images/icon_mini_faq.gif" width="12" height="13" alt="*" /> {L_FAQ}</a>
You could add a template loop there and then mod writers would simply have to put the link, img src, width, height, and alt in an array and have the template engine parse it. Then they would not need to edit the tricky header and worry about when people start using a bunch of other styles.

It could be something like:

Code: Select all

<!-- BEGIN header_links -->
<a href="{header_links.URL}"><img src="{header_links.IMG_SRC}" width="{header_links.WIDTH}" height="{header_links.HEIGHT}" alt="{header_links.ALT}" /> {header_links.TEXT}</a>
<!-- END header_links -->
Wouldn't be too hard to add, and would probably save some headaches and work later on. :)
User avatar
Highway of Life
Registered User
Posts: 1399
Joined: Tue Feb 08, 2005 10:18 pm
Location: I'd love to change the World, but they won't give me the Source Code
Contact:

Re: Header links...

Post by Highway of Life »

I don't like that idea at all...

It’s much easier and better to control the individual links, their placement, and the control statements of when they will appear if they are isolated elements rather than if they are restricted in a loop.
Plus there are so few link anyways, it’s not that big of a deal to just move or manipulate them how you want them. :)
Image
User avatar
Dog Cow
Registered User
Posts: 271
Joined: Wed May 25, 2005 2:14 pm

Re: Header links...

Post by Dog Cow »

Highway of Life wrote: It’s much easier and better to control the individual links, their placement, and the control statements of when they will appear if they are isolated elements rather than if they are restricted in a loop.
Plus there are so few link anyways, it’s not that big of a deal to just move or manipulate them how you want them. :)


But the whole point is to make it easier for MOD authors and newbies to phpBB MODing and HTML.
User avatar
Handyman
Registered User
Posts: 522
Joined: Thu Feb 03, 2005 5:09 am
Location: Where no man has gone before!
Contact:

Re: Header links...

Post by Handyman »

well… I could see something like making a links.html and putting the links section in there… then including it in the overall_header.html… but why? there's not much in the overall_header to begin with.
My phpBB3 Mods || My Mod Queue
Search Engine Friendly (SEO) URLs || Profile link on Avatar and/or Username || AJAX Chat
Display Posts Anywhere || CashMod || AJAX Quick Edit || AJAX Quick Reply

Image
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Header links...

Post by EXreaction »

Handyman wrote: well… I could see something like making a links.html and putting the links section in there… then including it in the overall_header.html… but why? there's not much in the overall_header to begin with.


But that wouldn't really help...

I am not trying to make it shorter in the overall_header.html area, I am just trying to make it so that it will be much easier for mod authors to add a link in the header, so they will not have to edit the template manually at all. If you ever had a semi-popular mod you know how bad it can be when other templates are starting to be used. Some people just don't install anything on the other templates, some completely put it in the wrong places, and with some styles the header won't be anything at all like subSilver, so you will pretty much have to do the edit for them...

Trying to get other templates to work is not always a fun experience. There may be a few other places that could have a loop like I mentioned to make it easy for mod authors as well(off the top of my head, on view topic, or memberlist view).

Mod authors do not have to use the loops either if they want it in a specific place, the ones who want to control exactly where it is will just have to deal with the problems it may bring with other styles. ;)
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Header links...

Post by EXreaction »

Anyone else? 8O
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Header links...

Post by EXreaction »

I think this needs another bump...

I want to hear what the devs think of it...
User avatar
poyntesm
Registered User
Posts: 176
Joined: Fri May 13, 2005 4:08 pm
Location: Dublin, Ireland
Contact:

Re: Header links...

Post by poyntesm »

Do not forget for prosilver its now all CSS based

Code: Select all

<a href="{U_FAQ}" title="{L_FAQ_EXPLAIN}" class="icon-faq">{L_FAQ}</a>&nbsp;
So really when a MOD author needs to do it now they need the CSS editted. I would prefer a method for MOD authors to have their css file included without having to edit and include another @import manually in stylesheet.css
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Header links...

Post by EXreaction »

Ya, I haven't gotten into the whole XHTML, tableless design, or CSS based stuff like that yet...


But wouldn't you still need to add a line like the following to the template:
<a href="{U_BLOG}" title="{L_BLOG_EXPLAIN}" class="icon-blog">{L_BLOG}</a>&nbsp;

And like you said, it would be extremely helpful if the templates automatically included CSS files in a certain folder. And it would be great if the parse_header() function automatically included files in a certain folder to be parsed. Then you could add all kinds of things without having to edit much, if anything at all. :D
User avatar
Handyman
Registered User
Posts: 522
Joined: Thu Feb 03, 2005 5:09 am
Location: Where no man has gone before!
Contact:

Re: Header links...

Post by Handyman »

You never have to edit much… currently you just edit the overall header to make it look however you want.
My phpBB3 Mods || My Mod Queue
Search Engine Friendly (SEO) URLs || Profile link on Avatar and/or Username || AJAX Chat
Display Posts Anywhere || CashMod || AJAX Quick Edit || AJAX Quick Reply

Image
Post Reply