Quote option like IPB2.0.0 (proposal from a phpBBuser \-.-\)

[DeadEye686]

dhn Wrote:
What now?


Just because it does not work in my browser . I'm using Safari... If you want more feedback, ask me. When I click "(??) quote" status bar indicates Launch script addquote(...) but this have no effect.

However, this works perfectly with Firefox

very COOL, thanks galga for the idea

'twas already there

[the_dan]

dhn Wrote:
What now?


Just because it does not work in my browser . I'm using Safari... If you want more feedback, ask me. When I click "(??) quote" status bar indicates Launch script addquote(...) but this have no effect.

However, this works perfectly with Firefox

very COOL, thanks galga for the idea

The idea:
Posted: 31 Aug 2004 12:24

The demonstration:
Posted: 31 Aug 2004 12:26

Remarkably quick implementation, don't you think?

Dan

[th23]

Hi,

I just played around a bit with the editor.js file. And that's what comes out of it... I know it's not perfect, but maybe some JS coder can have a look at it and it could be worth thinking about this approach...

Please note: I only tested it in Firefox/Mozilla, because I'm no expert in browser compatible JScript...

Code: Select all

if (theSelection == '')
	{
		if (document.all)
		{
			theSelection = divarea.innerText;
		}
		else if (divarea.textContent)
		{
			//theSelection = divarea.textContent;
			var todo = divarea.innerHTML;
			var left;
			var first;
			var m_text;
			var u_name;
			while (todo.indexOf('<div class="quotetitle"><b>') != -1) {
				first = todo.indexOf('<div class="quotetitle"><b>')
				left = todo.substring(0,first);
				todo = todo.substring(first + 27,todo.length);
				u_name = todo.substr(0,(todo.indexOf('</b></div>') - 7));
				todo = todo.substring(todo.indexOf('<div class="quotecontent">') + 26,todo.length);
				m_text = todo.substr(0,todo.indexOf('</div>'));
				todo = todo.substring(todo.indexOf('</div>') + 6,todo.length);
				todo = left + '[quote="' + u_name + '"]' + m_text + '[/quote]' + todo;
			}
			search_for = new RegExp('<div class="postbody">',"g")
			todo = todo.replace(search_for, '');
			search_for = new RegExp('</div>',"g")
			todo = todo.replace(search_for, '');
			search_for = new RegExp('<br>',"g")
			todo = todo.replace(search_for, '\n');
			theSelection = todo;
		}
		else if (divarea.firstChild.nodeValue)
		{
			theSelection = divarea.firstChild.nodeValue;
		}
	}

th23

[VxJasonxV]

I actually just got to try this in IPB. I would simply like to say, clicking quote, and then having the option of quoting further is AWESOME.

1) I don't know how IPB handles quoting across mutliple pages (something tells me it doesn't ) then phpBB has a slight edge because it has the set what, last 20 posts in the topic review iFrame?

2) I don't like having to click quote, and THEN click reply. If I want to quote only one post, it's annoying to activate the quote, THEN scroll to click reply, I truely see phpBB2.2's implementation of this as much more effecient.

3) If we should want to quote multple posts, then there should be a checkbox next to every quote button. But that's a IPB feature request, because phpBB will hopefully keep their current implementation.

[maxjackal]

i'm not a good coder but THERE MUST BE someone can do this..
i think this must have been fixed!

i want a fully working phpBB 2.2

You will have a fully working phpBB 2.2. As has been said, to be able to do this would require the devs to write a full-featured text parser in JavaScript, whose cost would outweigh its benefits. If you are quoting someone, why would you quote them as quoted by someone else instead of their actual quote? If you click 'quote' on the post responding to the original quote without selecting the text, you will have exactly what you want with even more clarity.

i did not think in that way
but in some cases anyone may need what i wrote
eg. in the topiv review part i can see only 10 posts..
if topic has more than 10 even 20 posts how can i quote a post which i cant see?

[hasten]

Amazing.

[Ivanime]

dhn Wrote:
What now?


Just because it does not work in my browser . I'm using Safari... If you want more feedback, ask me. When I click "(??) quote" status bar indicates Launch script addquote(...) but this have no effect.

However, this works perfectly with Firefox

very COOL, thanks galga for the idea

The idea:
Posted: 31 Aug 2004 12:24

The demonstration:
Posted: 31 Aug 2004 12:26

Remarkably quick implementation, don't you think?

Dan

¬¬* whatever, is a nice idea ò_ó

xDDDDDDD

[Galga]

i'm not a good coder but THERE MUST BE someone can do this..
i think this must have been fixed!

i want a fully working phpBB 2.2

You will have a fully working phpBB 2.2. As has been said, to be able to do this would require the devs to write a full-featured text parser in JavaScript, whose cost would outweigh its benefits. If you are quoting someone, why would you quote them as quoted by someone else instead of their actual quote? If you click 'quote' on the post responding to the original quote without selecting the text, you will have exactly what you want with even more clarity.

i did not think in that way
but in some cases anyone may need what i wrote
eg. in the topiv review part i can see only 10 posts..
if topic has more than 10 even 20 posts how can i quote a post which i cant see?

mhh you've a point in there.
though i think 10 posts are good & maybe giving anyone the possibility to quote older posts in a topic could cause some confusion [just imagine for example someone quotes one of the first posts in a topic of over 30 pages..]

[psoTFX]

Who says it will stay at 10 posts?

[David Robinson]

eg. in the topiv review part i can see only 10 posts..
if topic has more than 10 even 20 posts how can i quote a post which i cant see?

Press the quote button next to it in the actual topic