Quote option like IPB2.0.0 (proposal from a phpBBuser \-.-\)

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Post Reply
DeadEye686
Registered User
Posts: 448
Joined: Mon Jul 21, 2003 7:18 pm
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by DeadEye686 »

Ivanime wrote:
ybart10 wrote:dhn Wrote:
What now?


Just because it does not work in my browser . I'm using Safari... If you want more feedback, ask me. When I click "(??) quote" status bar indicates Launch script addquote(...) but this have no effect.

However, this works perfectly with Firefox
very COOL, thanks galga for the idea ;)
'twas already there ;)
User avatar
the_dan
Registered User
Posts: 700
Joined: Thu Apr 01, 2004 7:36 pm

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by the_dan »

Ivanime wrote:
ybart10 wrote:dhn Wrote:
What now?


Just because it does not work in my browser . I'm using Safari... If you want more feedback, ask me. When I click "(??) quote" status bar indicates Launch script addquote(...) but this have no effect.

However, this works perfectly with Firefox
very COOL, thanks galga for the idea ;)
The idea:
Posted: 31 Aug 2004 12:24

The demonstration:
Posted: 31 Aug 2004 12:26

Remarkably quick implementation, don't you think? ;)

Dan
User avatar
th23
Registered User
Posts: 112
Joined: Sat Jul 03, 2004 4:26 pm
Location: Bonn, Germany
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser -

Post by th23 »

Hi,

I just played around a bit with the editor.js file. And that's what comes out of it... I know it's not perfect, but maybe some JS coder can have a look at it and it could be worth thinking about this approach...

Please note: I only tested it in Firefox/Mozilla, because I'm no expert in browser compatible JScript... ;)

Code: Select all

if (theSelection == '')
	{
		if (document.all)
		{
			theSelection = divarea.innerText;
		}
		else if (divarea.textContent)
		{
			//theSelection = divarea.textContent;
			var todo = divarea.innerHTML;
			var left;
			var first;
			var m_text;
			var u_name;
			while (todo.indexOf('<div class="quotetitle"><b>') != -1) {
				first = todo.indexOf('<div class="quotetitle"><b>')
				left = todo.substring(0,first);
				todo = todo.substring(first + 27,todo.length);
				u_name = todo.substr(0,(todo.indexOf('</b></div>') - 7));
				todo = todo.substring(todo.indexOf('<div class="quotecontent">') + 26,todo.length);
				m_text = todo.substr(0,todo.indexOf('</div>'));
				todo = todo.substring(todo.indexOf('</div>') + 6,todo.length);
				todo = left + '[quote="' + u_name + '"]' + m_text + '[/quote]' + todo;
			}
			search_for = new RegExp('<div class="postbody">',"g")
			todo = todo.replace(search_for, '');
			search_for = new RegExp('</div>',"g")
			todo = todo.replace(search_for, '');
			search_for = new RegExp('<br>',"g")
			todo = todo.replace(search_for, '\n');
			theSelection = todo;
		}
		else if (divarea.firstChild.nodeValue)
		{
			theSelection = divarea.firstChild.nodeValue;
		}
	}
th23
User avatar
VxJasonxV
Registered User
Posts: 341
Joined: Sun Mar 02, 2003 2:51 pm
Location: Castle Rock, CO
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by VxJasonxV »

I actually just got to try this in IPB. I would simply like to say, clicking quote, and then having the option of quoting further is AWESOME.

1) I don't know how IPB handles quoting across mutliple pages (something tells me it doesn't :P) then phpBB has a slight edge because it has the set what, last 20 posts in the topic review iFrame?

2) I don't like having to click quote, and THEN click reply. If I want to quote only one post, it's annoying to activate the quote, THEN scroll to click reply, I truely see phpBB2.2's implementation of this as much more effecient.

3) If we should want to quote multple posts, then there should be a checkbox next to every quote button. But that's a IPB feature request, because phpBB will hopefully keep their current implementation.
"If You Support It, They Will Come."
"Construction"
maxjackal
Registered User
Posts: 14
Joined: Tue Apr 01, 2003 11:07 pm
Location: 26 / TR
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by maxjackal »

DeadEye686 wrote:
maxjackal wrote:i'm not a good coder but THERE MUST BE someone can do this..
i think this must have been fixed!

i want a fully working phpBB 2.2
You will have a fully working phpBB 2.2. As has been said, to be able to do this would require the devs to write a full-featured text parser in JavaScript, whose cost would outweigh its benefits. If you are quoting someone, why would you quote them as quoted by someone else instead of their actual quote? If you click 'quote' on the post responding to the original quote without selecting the text, you will have exactly what you want with even more clarity.
i did not think in that way ;)
but in some cases anyone may need what i wrote
eg. in the topiv review part i can see only 10 posts..
if topic has more than 10 even 20 posts how can i quote a post which i cant see?
maxJackal
http://www.TurkBilgi.web.tr" target="_blank : Turkish phpBB Community
hasten
Registered User
Posts: 63
Joined: Mon Mar 31, 2003 7:49 am

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by hasten »

Amazing.
User avatar
Ivanime
Registered User
Posts: 32
Joined: Wed Dec 10, 2003 9:50 pm
Location: Santiago, Chile
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by Ivanime »

the_dan wrote:
Ivanime wrote:
ybart10 wrote:dhn Wrote:
What now?


Just because it does not work in my browser . I'm using Safari... If you want more feedback, ask me. When I click "(??) quote" status bar indicates Launch script addquote(...) but this have no effect.

However, this works perfectly with Firefox
very COOL, thanks galga for the idea ;)
The idea:
Posted: 31 Aug 2004 12:24

The demonstration:
Posted: 31 Aug 2004 12:26

Remarkably quick implementation, don't you think? ;)

Dan
¬¬* whatever, is a nice idea ò_ó

xDDDDDDD
User avatar
Galga
Registered User
Posts: 22
Joined: Wed Apr 21, 2004 2:06 pm

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by Galga »

maxjackal wrote:
DeadEye686 wrote:
maxjackal wrote:i'm not a good coder but THERE MUST BE someone can do this..
i think this must have been fixed!

i want a fully working phpBB 2.2
You will have a fully working phpBB 2.2. As has been said, to be able to do this would require the devs to write a full-featured text parser in JavaScript, whose cost would outweigh its benefits. If you are quoting someone, why would you quote them as quoted by someone else instead of their actual quote? If you click 'quote' on the post responding to the original quote without selecting the text, you will have exactly what you want with even more clarity.
i did not think in that way ;)
but in some cases anyone may need what i wrote
eg. in the topiv review part i can see only 10 posts..
if topic has more than 10 even 20 posts how can i quote a post which i cant see?
mhh you've a point in there.
though i think 10 posts are good & maybe giving anyone the possibility to quote older posts in a topic could cause some confusion [just imagine for example someone quotes one of the first posts in a topic of over 30 pages..]
User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by psoTFX »

Who says it will stay at 10 posts?
User avatar
David Robinson
Registered User
Posts: 16
Joined: Fri Jun 04, 2004 10:06 pm
Location: Omaha, Nebraska, USA
Contact:

Re: Quote option like IPB2.0.0 (proposal from a phpBBuser \-

Post by David Robinson »

maxjackal wrote:eg. in the topiv review part i can see only 10 posts..
if topic has more than 10 even 20 posts how can i quote a post which i cant see?
Press the quote button next to it in the actual topic ;)
Mmm... Forbidden Donut....
Post Reply