replacing corner images with invisible ones

All style (template, theme and imageset) related questions for the new release; advice, feedback here please.
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

replacing corner images with invisible ones

Post by Dragosvr92 » Sun Apr 15, 2012 1:58 am

The corners_right/left.png images have white corners instead of invisible ones.
This makes it a bit annoying when you want to change your background colour to something else, like a black colour, as you may see the white corners.
Change the Background colour here to a black one and you will see what im talking about...
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: replacing corner images with invisible ones

Post by Arty » Sun Apr 15, 2012 8:03 am

Those corner images no longer exist in 3.1
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: replacing corner images with invisible ones

Post by Dragosvr92 » Sun Apr 15, 2012 1:28 pm

Arty wrote:Those corner images no longer exist in 3.1
Because it uses border-radius, i guess, right?
Maybe we should fix the issue in 3.0
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: replacing corner images with invisible ones

Post by callumacrae » Sun Apr 15, 2012 2:28 pm

TheKiller wrote:
Arty wrote:Those corner images no longer exist in 3.1
Because it uses border-radius, i guess, right?
Maybe we should fix the issue in 3.0
There's not point in fixing it in 3.0 if it has been fixed in 3.1 already.
Made by developers, for developers!
My blog

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: replacing corner images with invisible ones

Post by Dragosvr92 » Mon Apr 16, 2012 2:22 am

If theres a security issue in 3.0, you wont bother fixing it, as it will be fixed in 3.1 ?
The last 3.0 released version should deal with most issues accoured at the time it was released.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: replacing corner images with invisible ones

Post by DavidIQ » Mon Apr 16, 2012 2:43 am

Security issues are different. This is obviously not a security issue. :roll:
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: replacing corner images with invisible ones

Post by Dragosvr92 » Mon Apr 16, 2012 3:06 am

Yes, i do know, but the idea is the same.
The last version should be as clean as it can be, right?
Is there a reason on wwhy this shouldnt be done, or wasnt done for all this years?
Its not like IE6 is still supported and you prefered not to bother, as they will look the same.. there were other browsers that supported invisible images.
Theres a IE hack to make them invisible there also, which could have benn included with phpbb.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: replacing corner images with invisible ones

Post by DavidIQ » Mon Apr 16, 2012 3:12 am

Well if you want to fix it yourself and send a pull request then by all means do that. Otherwise our resources are better spent working on 3.1 ;-)
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: replacing corner images with invisible ones

Post by Dragosvr92 » Mon Apr 16, 2012 5:43 pm

It doesnt take more than lets say 10 minutes to do so, especially for designers that know to use their photo-editor well.
I can try to modify them if they ill be used, and i wont bother making them for nothing.
More experienced people could do it fast and better than me tho....
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: replacing corner images with invisible ones

Post by Dragosvr92 » Tue Apr 17, 2012 6:59 am

After i posted here i re-checked them and noticed that they are indeed invisible, but they need the white thing, as thats whats round...
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply