Please note, I started writing the following 8 hours ago, but my net connection died, so it just stayed here. As such, some has been discussed, but there are some important points
______________________________
IMO
is unique, and
is also unique, and doesn't adress the same line at all.
....
And at the end, you guys are explaining me I can't set the comments I want to appear in the scripts (whatever they are), and that of course can't be accepted from my programmer's point of view. Comments through a developpement is the first indicator of the quality of this developpement I won't trust a script without any comments, and my first move is to add the missing comments in order to find the logical bugs that are everytime presents in those kind of scripts, and believe me, I have always found some in those cases, even on my own scripts.
Those lines are not unique, and Nuttzy has really addressed this. I cannot for the life of me understand why you are so incistant on this (not telling you to stop, but your arguments don't stand up IMO). You may make any comment you want, as long as it isn't a comment duplicating the code from all I can tell. If you want to make the comment
That won't stop the MOD from being EMC, I would still validate it, and the world would be happy (but you may see your name in some code of mine if you were to say that...). Comments on the functionality of code are very much so needed. Commenting out old code is
not something that shows the code is good. There are many cases where this just is not practicle. IN-LINE actions don't need to have the full line pasted as a comment in the MOD file. If EM does this, that is another story, but it isn't something a MOD author will need to do. Let me give you some code from my Set Poster MOD (that the person who wanted me to make the code never paid me like he said he would, but that is beside the point)
Code: Select all
#
#-----[ OPEN ]------------------------------------------
#
templates/subSilver/viewtopic_body.tpl
#
#-----[ FIND ]------------------------------------------
#
{postrow.IP_IMG}
#
#-----[ IN-LINE FIND ]------------------------------------------
#
{postrow.IP_IMG}
#
#-----[ IN-LINE AFTER, ADD ]------------------------------------------
#
{postrow.SETPOSTER_IMG}
This is, IMO, a good example of the need for not searching for the begining. The full line is (in subSilver)
Code: Select all
<td valign=\\\\"top\\\\" nowrap=\\\\"nowrap\\\\">{postrow.QUOTE_IMG} {postrow.EDIT_IMG} {postrow.DELETE_IMG} {postrow.IP_IMG}</td>
Now with the exception of a template that would use {postrow.IP} instead, this works just great, is unique, and allows for the template designer to do whatever they want.
Now onto the idea of comments. What would be the purpose of commenting out vanilla code as part of the MOD, and then adding changes after this? This causes redundancy and more of a headache. I understand using comments to remove a feature, allowing some other MOD to go through and modify this feature (but not have it take effect) but we still have issues. It is better, IMO, just to remove the code at let EM handle it. Consider the following case
Code: Select all
$bobman .= $retort . ' j00 R d4 sUkc';
Now ignore the usage of language in the code, that is beside the point. Consider someone wants to remove this from happening, and so changes the above to the following
Code: Select all
//$bobman .= $retort . ' j00 R d4 sUkc';
Now some other MOD wants to go through and add a slam to the above right after the $retor. So they do the following
Code: Select all
#-----[ FIND ]-----
$bobman .= $retort
#-----[ IN-LINE FIND ]-----
$retort
#-----[ IN-LINE AFTER, ADD ]-----
. $slam
This will fail using your methods, as the line would start as
//$bobman instead of simply
$bobman.
As such, lines must not be dependant on if there is a // in front or not.