01: MODing Philosophy

[Ptirhiik]

Give me the [mute] or [save] command, that's only what I've asked and still does .

Anyway, what I explain don't cover only the need to preserve precedent code : it is much more a general issue : use the good command at the good place : excessive in-line just set the mod more difficult to install and are the main source of errors while installing, excessive replace occurs to a higher risk of not being able to install a mod (as installing other templates does), excessive add would occurs in duplicate code at many spots, etc.

[-=ET=-]

So...?
What is the solution?

Keep in mind our goal which is to find the best and safer way to let EM install successfully the maximum of MODs.

So in this context, full lines FIND for REPLACE WITH will drastically decrease EM chances to succeed, and WILL create (even manually and you knows it) issues for users as they will not be able to find these full lines to replaces them (you can't separate the 2 issues: you need a full line FIND before a full line REPLACE WITH).

On the other hand, IN-LINE commands are a "bit" more risky if you don't use EM. But is it really a sufficient reason?
Manual installation compatibility is preserved with the current official phpBB MOD template, this is enough no?

In fact, my real opinion is that EM will be very powerful and safe enough, so the majority of MOD installations in the future will be proceed by EM. So the "little" difficulty occurred by the necessary use of IN-LINE commands for manual installation is a minor problem IMO.

And in case EM has trouble to install a MOD, don't forget that you may uninstall it safely, immediately after having install it and done some tests (before unlocking the board for users).

Then, I really think that manual MOD installation will decrease quickly as soon as an EM final release will be available.

Just my 2c

[Ptirhiik]

(../..)Keep in mind our goal which is to find the best and safer way to let EM install successfully the maximum of MODs.(../..)

No : as an author, my goals are to provide the best way to install a mod, whatever the tool is used.

[-=ET=-]

Ptirhiik

...full lines FIND for REPLACE WITH ... WILL create (even manually and you knows it) issues for users as they will not be able to find these full lines to replaces them (you can't separate the 2 issues: you need a full line FIND before a full line REPLACE WITH).

There is no solution in what you said. It's only a statement.
Even more it will be harder for a newbie to find where is the problem and proceed the in line add without precise instructions. I've already had many times this problem and that it's harder than an IN-LINE instruction.

Nothing is better for manual installation, that's wrong

[GPHemsley]

No : as an author, my goals are to provide the best way to install a mod, whatever the tool is used.

And the best method is using IN-LINE, is it not?

[Ptirhiik]

Not in any case : that's my point : no command is better than another : it is only the way you use it that makes the difference : use the right at the right place is the key .

[GPHemsley]

Well, yes, that's true. Replace is not necessarily \"evil\", but it certainly should only be used as a last resort, as IN-LINE commands would be better in most cases.

[SnowboardAlliance]

Here's an idea. When a line is In-Line Modified, The original should be commented directly before. Then, when EasyMOD does a find, and sees these lines (commented and modified), it can better figure out what to do, like ask for user input on the best way to change the line.

EDIT: example

Original Line

Code: Select all

if ( $mode == 'editpost' || $mode == 'delete' || $mode == 'poll_delete' )

After First MOD

Code: Select all

//if ( $mode == 'editpost' || $mode == 'delete' || $mode == 'poll_delete' )
if ( $modes == 'editpost' || $modes == 'delete' || $modes == 'poll_delete' )

New MOD looks for the original line but finds that it has been commented, and a modified line is just below
Tells user:

Code: Select all

Line 
"if ( $mode == 'editpost' || $mode == 'delete' || $mode == 'poll_delete' )"
Has been Modified by another MOD to 
"if ( $modes == 'editpost' || $modes == 'delete' || $modes == 'poll_delete' )"
Command was
... IN-LINE FIND - || $mode == 'poll_delete'
... In-LINE AFTER ADD - || $mode == 'bar'

So the user could enter how to do this line manually. Or, if possible, EASYMOD could figure out that only one small change has been made and add the code accordingly.

[Nux]

I would say this is a good one! The comment could include something like "EM oryginall" and do not always leave all the versions just the first one. Shouldn't be very complicated.