[PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

[PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by VSE » Wed Sep 07, 2016 4:13 pm

Now that we use s9e Text Formatter, I think it would be good to enable the use of its Media Embed plugin:
http://s9etextformatter.readthedocs.io/ ... /Synopsis/

At this point I think it's safe to say the ability to post embedded video or adio content is no longer something we can consider "bloat". It would, IMO, be a step forward towards modernity if we could make this a native feature, rather than expecting extensions to continue handling it.
Has an irascible disposition.

User avatar
rxu
Registered User
Posts: 124
Joined: Tue Apr 04, 2006 4:28 pm
Contact:

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by rxu » Wed Sep 07, 2016 4:30 pm

Totally agree, plus it'd be useful to simplify adding more media resources to embed to make it easily extendable.
Image

danchr
Registered User
Posts: 1
Joined: Wed Sep 07, 2016 6:51 pm

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by danchr » Wed Sep 07, 2016 7:12 pm

VSE wrote:
Wed Sep 07, 2016 4:13 pm
At this point I think it's safe to say the ability to post embedded video or adio content is no longer something we can consider "bloat". It would, IMO, be a step forward towards modernity if we could make this a native feature, rather than expecting extensions to continue handling it.
I can add to this point: not so long ago, a choir I sing in migrated our internal forum to phpBB, and our main use case for it is sharing the sheets and recordings we use. phpBB works very well for this — the only caveat is that iOS cannot play the files directly from the server, but I've posted patches to fix that.
VSE wrote:
Wed Sep 07, 2016 4:13 pm
Now that we use s9e Text Formatter, I think it would be good to enable the use of its Media Embed plugin:
http://s9etextformatter.readthedocs.io/ ... /Synopsis/
Well, at least for my use case, I'd want to be able to post the files to the board, as we lack the rights to publish them globally.

aleha
Registered User
Posts: 143
Joined: Tue Mar 26, 2013 2:19 am

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by aleha » Wed Sep 07, 2016 7:54 pm

I fully support this proposal by VSE.
I have been using the javascript of a 3.0 mod to emulate a media bbcode and I think a native media bbcode would be an excellent addition to phpbb 3.3!
Users want to play media links without leaving the forum :D

User avatar
Ger
Registered User
Posts: 270
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by Ger » Thu Sep 08, 2016 8:55 am

$this++;
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by Nicofuma » Thu Sep 08, 2016 9:07 am

By the way, there is already an extension made by Joshy: https://github.com/s9e/phpbb-ext-mediaembed
JoshyPHP wrote:
Member of the phpBB Development-Team
No Support via PM

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by VSE » Thu Sep 08, 2016 3:53 pm

Nicofuma wrote:
Thu Sep 08, 2016 9:07 am
By the way, there is already an extension made by Joshy: https://github.com/s9e/phpbb-ext-mediaembed
JoshyPHP wrote:
Right, but as I said, it's time this be native, not an extension. The extension is for 3.1, which is a more complicated implementation because 3.1 does not have textformatter.

But in 3.2/3.3, it's literally just enabling the plugin in textformatters configurator.
Has an irascible disposition.

User avatar
JoshyPHP
Registered User
Posts: 350
Joined: Fri Jul 08, 2011 9:43 pm

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by JoshyPHP » Thu Sep 08, 2016 4:25 pm

I think it's good to have it as an extension. Make an official extension for it and if you want users to have access to it right out of the box you can bundle it with phpBB itself.

One of the benefits of having it as an extension is that you can keep all the related code/files/templates together. Perhaps down the line you'll want to add a form in the ACP to add custom sites (like XenForo media sites for example) or something of the sort.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by DavidIQ » Thu Sep 08, 2016 5:32 pm

JoshyPHP wrote:
Thu Sep 08, 2016 4:25 pm
I think it's good to have it as an extension. Make an official extension for it and if you want users to have access to it right out of the box you can bundle it with phpBB itself.
But given that the s9e formatter is already in 3.2 how complex is such an extension actually going to be for that line? Is it just going to enable a feature that is already included? Because if that's the case then perhaps it is indeed better to just have this enabled by default and configurable in 3.3 and forward.
Image

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [PHPBB3-14775] Enable Media Embedding in posts (via s9e TextFormatter)

Post by Nicofuma » Thu Sep 08, 2016 5:38 pm

If we had a nice way to distribute a set of extensions within the package I'd say: let's do it as an extension. But we don't :/ So I think, that for now it should be in core but implemented as if it was an extension (ie: as decoupled as possible).
Member of the phpBB Development-Team
No Support via PM

Post Reply