[RFC] Remove innermost quote

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.2/Rhea branch. Everything listed in this forum will be available in phpBB 3.2.
User avatar
Mess
Registered User
Posts: 197
Joined: Wed Jun 13, 2012 10:14 am

Re: [RFC] Remove innermost quote

Post by Mess » Fri Jul 19, 2013 6:09 am

theallzaz wrote:Changing the style would be nice too. But i think we are changing this topic scope. This topic issue isn't related with the style, but the problem is: as admin, you can already set a limit to the depth for quotes. Right? But if you does that, when the user tries to Submit a message with quotes in excess, he is forced to manually remove it. If i am quoting a post with a lot of words, it becomes a boring task.

I think if i'm limiting the depth for quotes, obviously I want them to be automatically removed. The poster don't care with the forum quote limit, so is not nice to ask him to manually remove it. Well, just my opinion
+1

MaFeSa
Registered User
Posts: 69
Joined: Sun Aug 26, 2012 1:44 pm

Re: [RFC] Remove innermost quote

Post by MaFeSa » Fri Jul 19, 2013 7:32 am

I think if i'm limiting the depth for quotes, obviously I want them to be automatically removed. The poster don't care with the forum quote limit, so is not nice to ask him to manually remove it. Well, just my opinion
+1

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Remove innermost quote

Post by EXreaction » Fri Jul 19, 2013 2:14 pm

Changing the style is not out of the scope of the topic. The reason that quote depth limit was added in the first place is because the view topic page could become a huge ugly mess if too many quotes were nested. If the actual problem is fixed, that limit can be removed entirely.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove innermost quote

Post by imkingdavid » Fri Jul 19, 2013 10:56 pm

I don't think the limit should be removed. I think both issues should be solved; we should fix the issue with the style taking up so much space, and we should make the software automatically remove quotes beyond the maximum nesting depth.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Remove innermost quote

Post by brunoais » Sun Jul 28, 2013 9:31 pm

imkingdavid wrote:I don't think the limit should be removed. I think both issues should be solved; we should fix the issue with the style taking up so much space, and we should make the software automatically remove quotes beyond the maximum nesting depth.
This ^.
IMO the only thing left is to decide how should that be done.
Some say that the user should not be warned, others say that the user should be warned (like me)...
Where does that place us in? Behind an option?

User avatar
KurtisC
Registered User
Posts: 24
Joined: Tue Jul 01, 2014 10:14 pm

Re: [RFC] Remove innermost quote

Post by KurtisC » Tue Jul 01, 2014 10:44 pm

I stumbled upon this thread through a search because I wanted to automatically truncate quotes more than my set limit on the forum (which is set to one on mine).

As a site administrator, I'm not bothered about changing the styling or the way it looks particularly on the forum because at the end of the day, quotes are simply repeating what's been written already in a thread. I'm just interested in keeping the site looking clean, keep user friendliness to a maximum and ensure the site as a whole runs smoothly. Because of the limit with quotations, people had to manually remove them which caused problems on my board where people didn't know how to and the moderation team had to manually fill in quotes because the user took them out (so there was an ending quote tag but no beginning in most cases). If someone hits 'quote' on a post with more than one level, I would much prefer it if quotes were just automatically removed. No fuss.

I came across this mod which works perfectly fine at this present moment in time. It would be nice to have this automatically implemented in PHPBB, but that's the solution I was looking for (and I presume the reason this thread on here was created in the first place). Quite simply, this is what I'm looking for as far as this particular topic goes.
EXreaction wrote:I think to solve this, first we need to make sure we understand what the real problem is that we are trying to solve, them design a way to solve it appropriately.

Currently, the problem with unlimited quote depth is that if the quotes are nested too deeply (depending upon the browser window), messages will be stretched really long or be cut off and it becomes really difficult or impossible to read. This happens because we pad each quote by some number of pixels and display each quote the same (difficult to follow the message through quotes if it gets too deep).

One of the key items here is that output is dependent on browser width, so a mobile device might only work with 3 nested quotes while a large display might work with 20 nested quotes.

If this is the core problem with quotes we're trying to fix, using a fixed limit to the depth of nested quotes doesn't really make much sense. Rather, the display of quotes should be changed so that messages are not becoming stretched or cut off and following nested quotes isn't as difficult.
Personally, I find having too many quotes counter-intuitive and a stumbling block to discussions. I've been on many forums where someone has quote embedded five / ten / fifteen levels and responded with a one liner. It's a waste of screen-space and looks outright messy on people's screens. As a preference and a rule I enforce on my own websites, I prefer people to quote one level, two, three at the absolute top-end before thinking 'okay, this is too much now. Why've you included all this pointless guff?' I think someone already mentioned this, but most people don't bother filtering out the pointless information but hit 'quote' because they're directly responding to that post. All that's needed is to simply truncate the quote level that is set higher than what the administrator of the forum says; one in my case, and three by default.
theallzaz wrote:Changing the style would be nice too. But i think we are changing this topic scope. This topic issue isn't related with the style, but the problem is: as admin, you can already set a limit to the depth for quotes. Right? But if you does that, when the user tries to Submit a message with quotes in excess, he is forced to manually remove it. If i am quoting a post with a lot of words, it becomes a boring task.

I think if i'm limiting the depth for quotes, obviously I want them to be automatically removed. The poster don't care with the forum quote limit, so is not nice to ask him to manually remove it. Well, just my opinion
Agreed.

User avatar
JoshyPHP
Registered User
Posts: 350
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC] Remove innermost quote

Post by JoshyPHP » Sun May 17, 2015 8:28 pm

Nicofuma wrote:Someone should bump this topic sometime in 2015
Funny that you said that (no need to verify, that quote is 100% legit) because that's exactly what I was thinking! :roll:

I can implement the quote removal if you want it in 3.2. I need a Y/N decision on the following:
  1. Remove extra quotes from the text when the user click the "Quote" button
  2. Either:
    1. Display an error when the user tries to submit too many nested quotes (current behaviour)
    2. Automatically remove extra quotes from the submitted text, implemented in:
      1. posting.php
      2. message_parser
      3. the text_formatter.parser service
My preference goes to 1 + 2b-ii, although it would make sense to go with 2b-iii. The latter adds a @config dependency to the text_formatter.parser service, which doesn't feel right. The message_parser object should probably configure the parser service. Also, before anyone suggests going with 2a and 2b as an option, I'd rather not add another configuration setting.
Last edited by JoshyPHP on Sun May 17, 2015 11:58 pm, edited 1 time in total.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Remove innermost quote

Post by DavidIQ » Sun May 17, 2015 11:39 pm

I'd agree with 1 and 2b-i I think. Otherwise we'd be storing extra text that won't get displayed, I think? (2b-ii)
Image

User avatar
JoshyPHP
Registered User
Posts: 350
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC] Remove innermost quote

Post by JoshyPHP » Sun May 17, 2015 11:57 pm

No, it would store the same thing in the DB. posting.php uses an instance of message_parser which in turns calls the text_formatter.parser service. posting.php is used when submitting posts but I don't know whether it's used by anything else. The message_parser is used by everything that uses rich text, AFAIK.

Just writing about it makes me realize that it should clearly be 2b-ii because that's how every other settings work: max_font_size, max_img_height, max_img_width, max_smilies and max_urls. They are all set by message_parser. I'm going to edit the post accordingly.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Remove innermost quote

Post by DavidIQ » Mon May 18, 2015 12:00 am

Sounds good to me then. I'm just realizing that 1 will remove the extra quotes anyways. So +1 on what you said.
Image

Post Reply