[RFC|Rejected] theme hook

These event requests have either been rejected by the community or have become redundant because of code changes or other events requests.
Post Reply
User avatar
tmbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

[RFC|Rejected] theme hook

Post by tmbackoff » Fri Jun 15, 2012 4:12 pm

Allowing authors to add theme files to the current theme set. This is more geared toward prosilver, as subsilver places all CSS in one single file. Our current setup shows the following (example only, 1 line):

Code: Select all

@import url("common.css");
Adding an additional parameter to import custom CSS files would be beneficial to those wishing to style their extensions a certain way without having to rely on the phpBB-provided CSS.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] theme hook

Post by Oleg » Fri Jun 15, 2012 4:25 pm

This should be doable via a hook in overall header:

https://github.com/p/phpbb3-ext-overall-header-addition

+ template inheritance for adding files.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] theme hook

Post by MichaelC » Fri Jun 15, 2012 4:39 pm

I agree with oleg that this is already doable.

Unless there is a reason why it wouldn't work then I'll reject this.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply