Update method for using Icons

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
Locked
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Update method for using Icons

Post by hanakin »

All the icons on phpbb are currently individual gif/png files. Not to mention that the way in which they are coded is not consistent with the current standard for utilizing icons across the web to be compatible with other popular icon based libraries.

I propose that we first merge these icons into 1 or more sprites. Then recode all the implementations to reflect the <i></i> based approach so that our theme authors can more effectively swap in their own icons either via their own sprite files or an icon based approach.

Their may be an issue in IE8 in which we would have to provide a work around but I believe its only an issue if you are running IE8 on Windows 7 which if extremely rare anyway.

Also if we recreate all the icons at a larger since we can also gain retina support. We might have to make some subtle changes to the icons though.

What we gain:
  1. More semantic code
  2. Less code to work with
  3. Reduced server load with faster page loads
  4. Easier integration with third party resources.
  5. Retina Support
Donations welcome via Paypal Image

User avatar
Darkness_demoN
Registered User
Posts: 89
Joined: Mon Jul 29, 2013 1:48 pm
Contact:

Re: Update method for using Icons

Post by Darkness_demoN »

+1

User avatar
Meis2M
Registered User
Posts: 448
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: Update method for using Icons

Post by Meis2M »

can u show a pic?

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Update method for using Icons

Post by hanakin »

I am working on them currently but it takes time as their are a lot of icons to replace
Donations welcome via Paypal Image

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Update method for using Icons

Post by hanakin »

ok so I managed to put together a WIP of the new icons. Note some were changes to be consistent with style as well as adhere to a consistent scale. I also consolidated some icons as well as added potentially useful icons and removed unnecessary ones

keep in mind its still a work in progress, so please provide feedback on any of the icons. As well as suggestions for more additions, and consolidation.
Screen Shot 2014-05-29 at 11.53.50 PM.png
(69.29 KiB) Downloaded 1185 times
TODO:
  1. Generate 2x version.
  2. Generate half size version for those icons that may be too large ie: little post icons
  3. Completely redesign the contact icons to be social icons as it makes more sense.
  4. Remove all current icon functionality from the them.
  5. Add in all new functionality for icons that adhere to current icon implementation standards
Donations welcome via Paypal Image

User avatar
Meis2M
Registered User
Posts: 448
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: Update method for using Icons

Post by Meis2M »

so good hanakin

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Update method for using Icons

Post by nickvergessen »

Let's just switch to FA in 3.2 instead of changing it twice in a row
Member of the Development-TeamNo Support via PM

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Update method for using Icons

Post by hanakin »

nickvergessen wrote:Let's just switch to FA in 3.2 instead of changing it twice in a row

That was the goal I was just trying to transition it for those who may want to utilize it know by switching out they way it's currently coded
Donations welcome via Paypal Image

User avatar
BTRFISHING
Registered User
Posts: 8
Joined: Fri Dec 20, 2013 3:13 pm
Contact:

Re: Update method for using Icons

Post by BTRFISHING »

nickvergessen wrote:Let's just switch to FA in 3.2 instead of changing it twice in a row
That would be great.... it would also be great to see bootstrap used as well ( but that's just my opinion :) )

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Update method for using Icons

Post by hanakin »

bootstrap will not fit prosilver compatibility however can be their in a new theme if and/or when it happens
Donations welcome via Paypal Image

Locked