[RFC|Rejected] Announcement Feed

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Announcement Feed

Post by bantu »

imkingdavid wrote:
Oleg wrote:Ideally this should be an extension that admins opt-in into.
Fair enough. I just figured from the amount of support I had received that it might be a nice addition.
It took a while until I realised it. Sorry for wasting your time. But maybe you can also take the suggestions and make an extension for 3.1 out of it. :)

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Announcement Feed

Post by imkingdavid »

bantu wrote:
imkingdavid wrote:
Oleg wrote:Ideally this should be an extension that admins opt-in into.
Fair enough. I just figured from the amount of support I had received that it might be a nice addition.
It took a while until I realised it. Sorry for wasting your time. But maybe you can also take the suggestions and make an extension for 3.1 out of it. :)
No worries; it didn't take long at all to adapt the MOD code into the code base. I'll most likely continue it for 3.1 when that comes out.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] Announcement Feed

Post by naderman »

Personally I think this would be a good thing to display on the ACP (although not at the top). It would certainly allow us to engage the phpBB community more than we currently do. However I would probably simply implement this through an iframe rather than loading it and outputting it in the template. What do you guys think about that?

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Announcement Feed

Post by Oleg »

You cannot delete a pull request, but you can close it. Use the button on the bottom.
naderman wrote:Personally I think this would be a good thing to display on the ACP (although not at the top). It would certainly allow us to engage the phpBB community more than we currently do. However I would probably simply implement this through an iframe rather than loading it and outputting it in the template. What do you guys think about that?
I like the iframe approach if it can be made to look reasonably well because then we're not injecting code from the internet on our pages. But then phpbb.com/whoever provides announcements has urls to installations via referer headers. Hmm.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] Announcement Feed

Post by naderman »

Well if you don't want phpbb.com to get a referer header, then don't click the links. Besides, is the referer of an iframe link even the parent window and not the iframe url itself?

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Announcement Feed

Post by callumacrae »

imkingdavid wrote:
Oleg wrote:Ideally this should be an extension that admins opt-in into.
Fair enough. I just figured from the amount of support I had received that it might be a nice addition. At least I got some more experience with the coding guidelines and using git and such. How do I delete a pull request?
Just close it (theres a big button beside the comment form)
Made by developers, for developers!
My blog

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: [RFC] Announcement Feed

Post by Danielx64 »

naderman wrote:Well if you don't want phpbb.com to get a referer header, then don't click the links. Besides, is the referer of an iframe link even the parent window and not the iframe url itself?
I think so yes, I will need to do some testing on that one as I am not 100% sure on it.

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: [RFC] Announcement Feed

Post by A_Jelly_Doughnut »

What is the status on this? GitHub pull request was closed, but re-opened by David. Discussion here sounds like a down vote? Was there some back-channel discussion, or is this considered rejected?
A_Jelly_Doughnut

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Announcement Feed

Post by imkingdavid »

A_Jelly_Doughnut wrote:What is the status on this? GitHub pull request was closed, but re-opened by David. Discussion here sounds like a down vote? Was there some back-channel discussion, or is this considered rejected?
Sorry must have accidentally clicked reopen. I'll re-close it.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Rejected] Announcement Feed

Post by Oleg »

Marking rejected per previous post.

Post Reply