[RFC|Rejected] disable banning / warning groups

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
User avatar
tbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

[RFC|Rejected] disable banning / warning groups

Post by tbackoff »

I wrote a MOD for phpBB 3.0.x that adds this functionality, but decided to post a RFC for adding this to the core. Basically, the MOD allows users with the manage groups permission to tick checkboxes ("group can be warned" and "group can be banned"). If a group can't be warned or banned, the appropriate links are removed from the member profile and viewtopic. Also, for users that think they are cleaver, I've added a check so that typing in a link to warn or ban a user will present an error message saying the user is a member of a group that can't be warned or banned. Users with FOUNDER status can warn and ban users in groups where it is disabled.

The only drawback with my MOD (that I can think of at the moment), is that if you try to ban multiple users, and one of those users is in a group that can't be banned, the error message pops up explaining that. This is less-than-ideal, as I think the best solution would be to ban the users that can be banned, and then present a message saying that such-and-such user couldn't be banned because they are in a group that can't be banned.

The other downside is that this MOD uses the hooks feature to grab each post from viewtopic, analyze whether the user is in a group that can be warned, and then edit the postrow accordingly. One of the developers may want to chime in on this, but I believe this process is slow++. Would adding code to viewtopic.php make it faster? :?

I'd like to hear thoughts about this for 3.2.x.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] disable banning / warning groups

Post by Oleg »

(14:50:52) t_backoff: nn- I think I got everything done... can you look at this and we can include it in 3.1? viewtopic.php?p=232045#p232045
(14:51:22) nn-: i see some obvious cosmetic deficiencies
(14:51:37) t_backoff: how so?
(14:51:51) nn-: https://github.com/t-backoff/phpbb3/com ... 31#L14R612
(14:52:11) t_backoff: opps, frogot to clean that part up
(14:52:17) nn-: regarding whether to include something, i don't decide that unilaterally
(14:52:43) nn-: we have an unconditional prohibition on founder banning, correct?
(14:52:57) bantu: yes
(14:52:58) t_backoff: correct, founders can ban regardless
(14:53:43) nn-: so what would be a use case for prohibiting banning of a group?
(14:55:09) t_backoff: for example, if you don't want a certain group to be banned or warn (you can pick and choose)
(14:55:22) t_backoff: global moderators can ban administrators (non-founders)
(14:55:29) nn-: why would someone need it?
(14:55:43) nn-: the reason for founder ban prohibition is to avoid a denial of service
(14:55:43) t_backoff: cleanup https://github.com/t-backoff/phpbb3/com ... 47ea8ef56c
(14:56:04) t_backoff: yes, founders CANT be banned, but administrators (non-founders) can
(14:56:05) nn-: it guarantees there is always *someone* who has admin privileges and is able to login to the board
(14:56:46) nn-: outside of that, if one admin banned another admin you ban the first admin and problem is solved
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] disable banning / warning groups

Post by naderman »

I'm not entirely sure I understand the purpose of this feature. It seems like you should just remove permissions from whoever abuses their power and reset the ban/warning they incorrectly issued. The un-bannable founder makes sure that someone can always get in to correct the bans and change permissions. This seems like more options in the ACP - making usability worse - without a real need.
User avatar
tbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

Re: [RFC] disable banning / warning groups

Post by tbackoff »

The idea was to prevent it from happening in the first place. Like I said on IRC last night, a board I moderated had a disgruntled moderator that went in and banned everyone in sight (except, of course, the founder). It was requested by them and that's why the MOD exists for 3.0.x. I figured that it would be useful for a future release, so I made the changes and committed to my forked copy.

I'm also understanding and if the Development Team doesn't see a real need for this, then it can be marked as rejected and I'll just continue to offer it as a MOD.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] disable banning / warning groups

Post by Oleg »

In light of http://www.phpbb.com/community/viewtopi ... &t=2145817 giving disgruntled admins the power to ban people is not so bad.
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] disable banning / warning groups

Post by naderman »

I don't see how that topic relates to this RFC at all?
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] disable banning / warning groups

Post by Oleg »

If you have a disgruntled admin, they might ban everyone in sight and be satisfied enough. The bans are easily reversible, no real damage is done. Now if you prohibit banning said disgruntled admin might have to be more creative and they could realize that they have the power to delete half the board before someone catches on.
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] disable banning / warning groups

Post by naderman »

Ah I see. So personally I'd prefer this RFC be rejected. Other votes from anyone?
User avatar
tbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

Re: [RFC] disable banning / warning groups

Post by tbackoff »

Reject it please. I have no other points to make.
Post Reply