new topic lock option...

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
neuropass
Registered User
Posts: 22
Joined: Thu Apr 11, 2013 7:24 pm

Re: new topic lock option...

Post by neuropass » Thu Feb 12, 2015 3:01 am

one of those wtf moment. why was this never implemented I have no clue. definitely part of the core not an extension.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: new topic lock option...

Post by nickvergessen » Thu Feb 12, 2015 1:36 pm

neuropass wrote:one of those wtf moment. why was this never implemented I have no clue. definitely part of the core not an extension.
Well the RFC forums are currently unusable because they are used for many different things at the same time.
I created a ticket for it: https://tracker.phpbb.com/browse/PHPBB3-13598
Member of the Development-TeamNo Support via PM

neuropass
Registered User
Posts: 22
Joined: Thu Apr 11, 2013 7:24 pm

Re: new topic lock option...

Post by neuropass » Thu Feb 12, 2015 1:41 pm

Thanks Nick. That's great. Much appreciated.

User avatar
spaceace
Registered User
Posts: 11
Joined: Thu Dec 04, 2014 4:33 pm
Location: Ontario Canada
Contact:

Re: new topic lock option...

Post by spaceace » Fri Mar 20, 2015 12:36 pm

nickvergessen wrote:
neuropass wrote:one of those wtf moment. why was this never implemented I have no clue. definitely part of the core not an extension.
Well the RFC forums are currently unusable because they are used for many different things at the same time.
I created a ticket for it: https://tracker.phpbb.com/browse/PHPBB3-13598
thank you. i'm trying to figure out how exactly to submit a pull request for the patch for this and why does this process have to be so complicated? post here, ticket there, branch to be this, make changes and do a pr... i can't seem to figure it out cause it's got so many steps that have to be taken. i'm sure i'll get it once i do actually figure it out.

an easy way to explain... i'm a concrete finisher by trade. give me 20,000 square feet of floor to finish... no problem. not knowing any of you here... but you might look at that and say OMG!!!!!!! i can't do that... now, for me to get this pull request figured out... i'm just a concrete guy that needs help :lol:

User avatar
spaceace
Registered User
Posts: 11
Joined: Thu Dec 04, 2014 4:33 pm
Location: Ontario Canada
Contact:

Re: new topic lock option...

Post by spaceace » Sun Mar 22, 2015 11:36 am

https://github.com/phpbb/phpbb/pull/3495

i'm hoping i did it right :?

Post Reply