[RFC] Poll results bar relative width

[PayBas]

Currently, the bars indicating the results of a poll represent the width as an absolute percentage. The result is that when there are multiple poll options that all get about the same amount of votes, the result bars tend to get really short, and not very descriptive. I suggest making the "winning" poll bar 100%, and all other widths relative to it. This is much more esthetically pleasing if you ask me, because it really gives users something to look at. Additionally, I add a "winner" class to the winning poll bar, so it's easier to style it in a special way.

I have already been using this for a long time, using a Javascript method in the footer, but I thought it might be interesting to others (and perhaps inclusion into the core some day).

Code: Select all

<!-- IF S_HAS_POLL and S_DISPLAY_RESULTS -->
var maxperc = 0;
$("dd.poll_option_percent").each(function() {
	var perc = parseFloat($(this).html());
	maxperc = ( perc > maxperc ? perc : maxperc );
})
if (maxperc !== 0) {
	$("fieldset.polls > dl").each(function() {
		if($(this).is("[data-poll-option-id]")) {
			var perc = parseFloat($("dd.poll_option_percent", this).html());
			if (perc == maxperc) {
				$(this).addClass("winner");
			}
			perc = Math.round(perc / maxperc * 100);
			$("dd.resultbar > div", this).css("width", perc+"%");
		}
	})
}
<!-- ENDIF -->

poll.png

(29.89 KiB) Downloaded 713 times

[M.Gaetan89]

I like the idea.
Currently the bars width is calculated zith PHP (variable {poll_option.POLL_OPTION_PERCENT} in the template) and I think we should keep the logic there, not adding JS to do this.

[PayBas]

I like the idea.
Currently the bars width is calculated zith PHP (variable {poll_option.POLL_OPTION_PERCENT} in the template) and I think we should keep the logic there, not adding JS to do this.

Of course I agree, sorry if I wasn't clear . A PHP solution would be much better.

I just posted this as a proof-of-concept.

[Mess]

Good idea. I like it.

[PayBas]

Ticket: http://tracker.phpbb.com/browse/PHPBB3-12327
Pull request: https://github.com/phpbb/phpbb/pull/2209