[RFC] Remove AutoMOD During Migration

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
MattF
Extension Customisations
Extension Customisations
Posts: 675
Joined: Mon Mar 08, 2010 9:18 am

[RFC] Remove AutoMOD During Migration

Post by MattF »

If a 3.0.X board has AutoMOD installed, and you update this board to 3.1, some of AutoMOD's remnants in the database are of issue.

Most obvious is the old AutoMOD tab is left behind, but will appear as "ACP_CAT_MODS" and clicking on it leads to General Errors because AutoMOD files can not be found or loaded. It's because the AutoMOD Module is left behind in the DB. This means the admin (as of right now) has to dig into the Module Management system to remove this "dead" tab/module.

Since AutoMOD is an "official" tool, and installed on a lot of boards, wouldn't it make sense to have a migration file remove any AutoMOD related changes in the database, since they are totally obsolete in 3.1 anyways?

http://tracker.phpbb.com/browse/PHPBB3-11887
Has an irascible disposition.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Remove AutoMOD During Migration

Post by EXreaction »

Updates on boards with many mods installed may be problematic. The worst issue is typically when mods add extra columns to tables without defaults.

If automod isn't going to be updated to support 3.1, it may be a good idea to remove the module in a migration since it was quite a common tool. Otherwise we may want to look into recommending use of the support tool kit's database cleaner tool before updating.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Remove AutoMOD During Migration

Post by nickvergessen »

Did anyone test whether it still works or not?
Member of the Development-TeamNo Support via PM

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Remove AutoMOD During Migration

Post by Arty »

Doesn't it apply to all mods, not just AutoMOD?

None of old mods would work. I think it would be better to simply reset *CP modules.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Remove AutoMOD During Migration

Post by nickvergessen »

Arty wrote:None of old mods would work. I think it would be better to simply reset *CP modules.
A simple update of the module entry shoudl fix the *CP modules. So no need to remove them.

It's different with AutoMOD, if we decide to not make it work with 3.1
However if we do so, we should remove everything from automod correct, apart form the table which documents what was installed, so board admins still have that.
Member of the Development-TeamNo Support via PM

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Remove AutoMOD During Migration

Post by DavidIQ »

It was previously decided we (MOD Team) wouldn't be updating AutoMOD for 3.1 to further accelerate extension adoption. Furthermore it would need a rewrite if we were to consider it for use in 3.1.
Image

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Remove AutoMOD During Migration

Post by MichaelC »

Generate a text file somewhere perhaps with a list of mods installed. Then if they need support they can ask for the contents of that file (as opposed to looking in the db).
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply