Convert front-facing files to use the front controller

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Convert front-facing files to use the front controller

Post by imkingdavid » Sat Apr 27, 2013 7:25 pm

VSE+ wrote:
imkingdavid wrote:One dependency that must be sorted out prior to even beginning is the paths issue (in short, it's the difference between URLs that look like /app.php?controller=topic/1#p124 and URLs that look like /app.php/topic/1#p124 or (using URL rewriting) /topic/1#p124. If we do not sort this out first, we will be breaking URLs twice (when it eventually does get sorted out), which is not acceptable.
FYI: In its current state, the meta_refresh function fails to handle controller file URLS right now... because it likes to filter out any slashes that appear among the URL params... So for now, a url like /app.php?controller=topic/1#p124 can not be handled by the meta_refresh function. It would redirect you instead to /app.php?controller=topic. It may probably also fail to handle /app.php/topic/1#p124 formatted URLs too.
Alright, thanks. I'll look into it.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: Convert front-facing files to use the front controller

Post by naderman » Mon Apr 29, 2013 11:39 am

On the subject of slugs you should review the [RFC] Human Readable URLs topic.

Generally speaking +1 on the proposal, would certainly like to eliminate the duplicated code and multiple entry points we currently have.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Convert front-facing files to use the front controller

Post by imkingdavid » Sat May 04, 2013 4:59 am

To update, I missed to GSoC deadline on accident :roll: so this will likely be pushed back in favor of getting 3.1 blockers fixed and getting the post revisions feature ready for potential inclusion in either 3.1 or 3.2, depending on timing.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Convert front-facing files to use the front controller

Post by imkingdavid » Tue May 07, 2013 3:06 pm

Also, for anyone interested in helping out (since it is no longer specifically my project), I have started work on this on the following branch.
Branch
Comparison
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply