[RFC] AJAX Quick Edit

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
_hsr
Registered User
Posts: 42
Joined: Mon Mar 26, 2012 7:06 am

Re: [RFC] AJAX Quick Edit

Post by _hsr » Thu Apr 12, 2012 7:30 pm

editing posts require BBCodes, but this is negotiable once a RTE is added to phpbb
There is a text here !

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Mon Apr 16, 2012 12:19 am

marc1706 wrote:A few things that need to be decided:
  • Should the edit button in the mcp also have a quick edit function?
  • How about the PM area?
  • Include BBCodes or not?
I'd say don't add BBCodes especially since the quick reply doesn't have bbcodes either.
Here is my opinion
  • MCP may include quick edit.
  • In PM area, drafts may be quick edited
  • Include bbCodes, as it would provide easier formatting
P.S I'd suggest to enable bbcodes in quick reply too.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: [RFC] AJAX Quick Edit

Post by Danielx64 » Wed Nov 20, 2013 11:51 am

Yes for ajax editing with bbcodes although there may be issues with layouts

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] AJAX Quick Edit

Post by VSE » Fri Apr 11, 2014 4:42 pm

Marc wrote:A few things that need to be decided:
  • Should the edit button in the mcp also have a quick edit function?
  • How about the PM area?
  • Include BBCodes or not?
I'd say don't add BBCodes especially since the quick reply doesn't have bbcodes either.
Resurrecting this, as its something phpBB should have.

Marc, it looks like you had something in place already (all the hard works is done)... just needs implementing.
Has an irascible disposition.

User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: [RFC] AJAX Quick Edit

Post by Jessica. » Fri Apr 11, 2014 5:52 pm

The quick edit, I think, should be similar to the quick edit in the mods database topics on phpBB.com. The quick edit is inline, not a pop up, but there are also BBCodes and of course an "Advanced Edit" (or full editor, whatever works)

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 122
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Fri Apr 11, 2014 8:58 pm

I have created a ticket for this: https://tracker.phpbb.com/browse/PHPBB3-12393

edit: I have also created a WIP PR for this:
https://github.com/phpbb/phpbb/pull/2295

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] AJAX Quick Edit

Post by VSE » Fri Apr 11, 2014 10:04 pm

Marc wrote:I have created a ticket for this: https://tracker.phpbb.com/browse/PHPBB3-12393

edit: I have also created a WIP PR for this:
https://github.com/phpbb/phpbb/pull/2295
Awesome!!!

I think, as discussed earlier in this thread, the existing Edit button should open up the quick edit, and like quick reply, there would be a Full editor button available should a user want to switch to that.
Has an irascible disposition.

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 122
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Fri Apr 11, 2014 11:02 pm

The current WIP quickedit does behave that way. ;)
Clicking on the edit button a second time actually opens up the full editor, too.
This is triggered by jQuery code that is returned with the AJAX request so an accidental double-click shouldn't cause one to accidentally go to the full editor. :)

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] AJAX Quick Edit

Post by VSE » Sat Apr 12, 2014 12:02 am

Marc wrote:The current WIP quickedit does behave that way. ;)
Clicking on the edit button a second time actually opens up the full editor, too.
This is triggered by jQuery code that is returned with the AJAX request so an accidental double-click shouldn't cause one to accidentally go to the full editor. :)
perfect... It'll be great to see your Quick edit...turned AJAX Quick Edit...evolve into a part of phpBB for reals!
Has an irascible disposition.

User avatar
NORDLANDVOLK
Registered User
Posts: 44
Joined: Thu Oct 14, 2010 8:14 pm
Location: Tracia

Re: [RFC] AJAX Quick Edit

Post by NORDLANDVOLK » Sat Apr 12, 2014 10:26 am

it will be nice to be ajax in submit-buttons as well, nice work Marc.
sorry for my bad english :oops:

Post Reply