How many times have you guys hit the topic character limit? I know I did, especially if its a news forum which I know it isn't the primary reason to use phpBB but I think its a fair request.
Doing changes directly on the database could be a bit scary if you don't know what you're doing. So I'm requesting to make more space for topic titles or let admins configure it they want to, because I know this could break some templates.
Ticket: http://tracker.phpbb.com/browse/PHPBB3-10640
PR: https://github.com/phpbb/phpbb3/pull/571
[RFC] Bigger topic title lenght limit
[RFC] Bigger topic title lenght limit
Last edited by Vinny on Sat Jun 02, 2012 6:26 pm, edited 1 time in total.
Reason: Adds ticket and PR links
Reason: Adds ticket and PR links
Slightly better English than it was in 2005, still improving
Re: [RFC] Bigger topic title lenght limit
By stating bigger.... How bigger are you thinking?
Re: [RFC] Bigger topic title lenght limit
I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
Re: [RFC] Bigger topic title lenght limit
+1. Its way too easy to run into it at the moment. Its 64 characters.Oleg wrote:I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
I'll take a look at a patch for this at the weekend if nobody else is.
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: [RFC] Bigger topic title lenght limit
Time to learn how the database updater thing worksUnknown Bliss wrote:+1. Its way too easy to run into it at the moment. Its 64 characters.Oleg wrote:I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
I'll take a look at a patch for this at the weekend if nobody else is.
Re: [RFC] Bigger topic title lenght limit
That'll be more than enough for me, thanks!Oleg wrote:I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
Last edited by ecwpa on Fri Feb 10, 2012 9:46 pm, edited 1 time in total.
Slightly better English than it was in 2005, still improving
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Bigger topic title lenght limit
For whomever is going to do this, some additional info: The "topic_title" column in the phpbb_topics table is a VARCHAR(255). So the limit is in the software, meaning that you'll need to look, likely, in posting.php or functions_posting.php to find where it is limiting the length.
Also, the post_title length should be updated accordingly.
Also, the post_title length should be updated accordingly.
Re: [RFC] Bigger topic title lenght limit
Info:
Edit:
- Length: http://www.phpbb.com/community/viewtopi ... #p13029293
Changes infunctions_content.php
,posting_editor.html
andquickreply_editor.html
also. - ACP: http://www.phpbb.com/community/viewtopi ... &t=2111996
Edit:
I think it's the same function (imkingdavid wrote:Also, the post_title length should be updated accordingly.
truncate_string
).Re: [RFC] Bigger topic title lenght limit
I don't think we need an ACP setting for this but thanks for both links.
Do we want to go to 120/124 or 100/104 or 200/204 (second number is for if its a reply it needs to have topic title length plus 4 characters. Having them the same would chop of a 100 char topic title by 4 chars in all replies. - Re: (Space) TOPICSUBJECT.
I'll put up a PR tonight with 120 for now.
Do we want to go to 120/124 or 100/104 or 200/204 (second number is for if its a reply it needs to have topic title length plus 4 characters. Having them the same would chop of a 100 char topic title by 4 chars in all replies. - Re: (Space) TOPICSUBJECT.
I'll put up a PR tonight with 120 for now.
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
Re: [RFC] Bigger topic title lenght limit
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"