[RFC] Revamp of styles section of acp

[Arty]

This RFC is addition to [RFC] Merge style components

Introduction

With removal of styles components, theme and template sections of styles section of admin control panel become pointless. Layout will require moving stuff around.

Proposal

I propose to revamp styles section of admin control panel.

Menu on left side:
- Installed Styles (default item)
- Install Style
- Purge Cache

Installed Styles shows list of styles that are installed. It will be separated into two sections: active styles and inactive styles. Each row will have these items:
- Style name
- Used by, which shows number of users using it
- Default style column: radio box, allowing admin to quickly change default style
- Options block.

Options block in installed styles section will include:
- Activate / Deactivate (same as now)
- Details. This will allow admin to rename style and will show copyright, version and template inheritance information
- Edit. This will allow admin to edit css and template files. It will be shown as directory tree browser, allowing admin to select .html and .css files within style directory and edit them.
- Delete (same as now)
- Preview (same as now)

Install Style section will show list of available styles, similar to end of styles section now. In addition, if php has write permission to styles directory, it will have option to upload and install style.

Purge Cache section: copy of "purge cache" button from admin control panel index. It is confusing for users to having to go to acp index to clear compiled templates cache, so this menu item will help.

Patch
Ticket: click here
Pull request: click here

[hanakin]

+1 as long as you keep in the general section as well as its more convenient for me that way. also possibly consider adding setting to constantly refresh the stale theme here as well as under load settings because that more than anything is the most confusing thing for most users

[MichaelC]

For reference I found a MOD which uploads and deletes styles http://www.phpbb.com/community/viewtopi ... &t=2143122

[Arty]

I'm working on this right now and looking for feedback: which styles display method is better?

1. Alternate row colors by style level: uninstalled styles and installed styles
2. Alternate row colors for each row: uninstalled styles and installed styles

[MichaelC]

I'm working on this right now and looking for feedback: which styles display method is better?

1. Alternate row colors by style level: uninstalled styles and installed styles
2. Alternate row colors for each row: uninstalled styles and installed styles

Personally I think by style level looks better.

On a general note though, it looks nice.

[brunoais]

I think a 2 level speparating syling would be better.
The objective is to have separate style for the inner ones vs the outer ones.
For that we'd need 4 colors, though.
Having in account that imagem it would have the colors:
color1
color2
color3
color4
color1
color3
color4
color1

OR

color1
color2
color3
color4
color1
color3
color4
color2

What do you think?

[imkingdavid]

I'm working on this right now and looking for feedback: which styles display method is better?

1. Alternate row colors by style level: uninstalled styles and installed styles
2. Alternate row colors for each row: uninstalled styles and installed styles

#1 looks nicer.

Though there aren't very many styles to which this next bit applies, how does this handle styles that aren't based on prosilver or subsilver (i.e. complete rewrites). There's at least one in the styles in development forum, iirc that does that.

[Arty]

I think a 2 level speparating syling would be better.
The objective is to have separate style for the inner ones vs the outer ones.
For that we'd need 4 colors, though.

I like that idea!

how does this handle styles that aren't based on prosilver or subsilver (i.e. complete rewrites).

Styles are shown as tree based on template inheritance. prosilver and subsilver2 don't have parent styles, so they are shown on root level. Same applies to all other styles that don't have parent styles.

Even though template system supports only 1 level deep trees, code in styles management doesn't have that limitation, allowing to implement infinite level deep style trees.

[imkingdavid]

how does this handle styles that aren't based on prosilver or subsilver (i.e. complete rewrites).

Styles are shown as tree based on template inheritance. prosilver and subsilver2 don't have parent styles, so they are shown on root level. Same applies to all other styles that don't have parent styles.

Even though template system supports only 1 level deep trees, code in styles management doesn't have that limitation, allowing to implement infinite level deep style trees.

Ahh, right, that makes sense. Alright.

[Arty]

How about this? installed styles list, uninstalled styles