[RFC] Stop Supporting Subsilver

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] Stop Supporting Subsilver

Post by jsebean »

hanakin wrote:
jsbean wrote:im happy with the decision to keep subsilver supported in 3.1, since i use subsilver myself. However, for 3.2 I would not be mad if you would stop supporting subsilver, in fact i think its a good idea, subsilver is based on tables for the layout which is out of standards anyway. Maybe someone just make a subsilver3, based on prosilver, but keep the same old looks in general since i like the looks of subsilver2.

That's the idea first we need to clean up pro then it would be easy enough to make a theme based off of it to resemble sub
To follow up on this post, someone did make a subsilver3, since I changed to it on my board :D (Makes things so much easier :D) Though yes the post still makes sense. Anyone interested in subsilver3, i got no idea who made it but I think it's in the styles database.
-Jonah
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 941
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Stop Supporting Subsilver

Post by hanakin »

yes but its based off of prosilver which is a very old muttled piece of crap by todays standards
Donations welcome via Paypal Image
User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Stop Supporting Subsilver

Post by callumacrae »

hanakin wrote:yes but its based off of prosilver which is a very old muttled piece of crap by todays standards
Do you have anything to back up this statement? I definitely disagree with you.
Made by developers, for developers!
My blog
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 941
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Stop Supporting Subsilver

Post by hanakin »

callumacrae wrote:
hanakin wrote:yes but its based off of prosilver which is a very old muttled piece of crap by todays standards
Do you have anything to back up this statement? I definitely disagree with you.
apart from experience working with it and all forum software packages other than phpbb

the disscussion: viewtopic.php?f=108&t=35613
Donations welcome via Paypal Image
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Stop Supporting Subsilver

Post by MichaelC »

UKB|Debian> Whats going to happen with subsilver in the update? As its being removed from the default package. But what will happen with the updater package?
<UKB|Debian> Will the updater package include the subsilver updates, and if not, then will it un-install/delete subsilver or leave it or ..
<cyberalien> i'm not sure how to write a test for it
<igorw> UKB|Debian: I guess we'll include subsilver2 in the updater
<cyberalien> if(file_exists($phpbb_root_path . 'styles/subsilver2')) die('Please delete your forum.');
<UKB|Debian> ok, know its far off but what will then happen in 3.2
<cyberalien> that should do it for updater :)
<UKB|Debian> When its removed and stopped supported
<UKB|Debian> Will it un-install subsilver and delete it or ...?
<igorw> nobody knows
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Stop Supporting Subsilver

Post by Arty »

You forgot this part:
UKB|Debian: Arty: Syntax Error.
[12:09] UKB|Debian:
[12:09] igorw: UKB|Debian: where?
[12:10] igorw: I think you just nubbed yourself
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Stop Supporting Subsilver

Post by MichaelC »

Arty wrote:You forgot this part:
UKB|Debian: Arty: Syntax Error.
[12:09] UKB|Debian:
[12:09] igorw: UKB|Debian: where?
[12:10] igorw: I think you just nubbed yourself
Thanks Arty. :P Not my fault your semi-colon was off the screen. :lol:
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Stop Supporting Subsilver

Post by imkingdavid »

Unknown Bliss wrote:<UKB|Debian> ok, know its far off but what will then happen in 3.2
<UKB|Debian> When its removed and stopped supported
<UKB|Debian> Will it un-install subsilver and delete it or ...?
<igorw> nobody knows
IMO This would be an acceptable approach (although we should really wait to discuss this later, after 3.1 is out):
  1. If the board default theme is subsilver2 or based on subsilver2, switch it to prosilver. NOTE: If the board admin previously uninstalled prosilver and has no prosilver-based styles, the prosilver within the upgrade package should be installed onto the board and made default).
  2. Deactivate subsilver2 (and all subsilver2-based themes) and switch users that were on those themes to the board default theme.
  3. Display a notice/warning before and during upgrade process that this will happen, so that the admin does not freak out when their style is gone. Message should say that all subsilver2-based themes are being disactivated and that the user should search for acceptable prosilver-based themes to replace the subsilver2-based themes after the upgrade.

(because I'm too lazy to go back and change it myself, replace in your mind all above instances of "theme" with "style", since that's the correct terminology)
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Stop Supporting Subsilver

Post by MichaelC »

But a full version of prosilver won't ship with the update package. Only added files are shipped and if the whole thing is shipped it would wipe their current prosilver with all their edits.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Stop Supporting Subsilver

Post by brunoais »

imkingdavid wrote:
  1. If the board default theme is subsilver2 or based on subsilver2, switch it to prosilver. NOTE: If the board admin previously uninstalled prosilver and has no prosilver-based styles, the prosilver within the upgrade package should be installed onto the board and made default).
  2. Deactivate subsilver2 (and all subsilver2-based themes) and switch users that were on those themes to the board default theme.
  3. Display a notice/warning before and during upgrade process that this will happen, so that the admin does not freak out when their style is gone. Message should say that all subsilver2-based themes are being disactivated and that the user should search for acceptable prosilver-based themes to replace the subsilver2-based themes after the upgrade.

(because I'm too lazy to go back and change it myself, replace in your mind all above instances of "theme" with "style", since that's the correct terminology)
We should just stop supporting subsilver2, not make it disappear from the internet or the current forums.
subsilver should just be deactivated and can be activated by board admins if they want to. Just don't expect that subsilver2 will ever be kept updated. Someone has to do that job and it's not the phpbb dev members.
Post Reply