[RFC] BBCode permissions and moving to all custom

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
ecwpa
Registered User
Posts: 181
Joined: Mon Jan 24, 2005 2:10 am
Contact:

Re: [RFC] BBCode permissions and moving to all custom

Post by ecwpa » Sun Dec 09, 2012 6:51 pm

The carousel uses ID, check the first line:

Code: Select all

<div id="myCarousel" class="carousel slide">
If you remove id="myCarousel" it won't work. I know it could probably be rewritten to work without IDs but that's how most of these libraries work, this is the standard, not the exception.
Slightly better English than it was in 2005, still improving :D

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] BBCode permissions and moving to all custom

Post by brunoais » Sun Dec 09, 2012 7:15 pm

What does that have to do? The interest here is the js code, not the HTML.

ecwpa
Registered User
Posts: 181
Joined: Mon Jan 24, 2005 2:10 am
Contact:

Re: [RFC] BBCode permissions and moving to all custom

Post by ecwpa » Sun Dec 09, 2012 7:27 pm

Am I missing something? callumacrae asked why I need IDs, and I explained how lots of JS libraries requiere HTML IDs for them to work. I'm just answering his question.

EXreaction's solution is pretty good, it will work for me, unless JS is disabled, in that case I'm not sure what would happen.
Slightly better English than it was in 2005, still improving :D

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] BBCode permissions and moving to all custom

Post by brunoais » Sun Dec 09, 2012 8:06 pm

Show me an example of how you instantiate one of those libraries, pls.
ecwpa wrote:EXreaction's solution is pretty good, it will work for me, unless JS is disabled, in that case I'm not sure what would happen.
Nothing.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] BBCode permissions and moving to all custom

Post by callumacrae » Sun Dec 09, 2012 8:25 pm

The first one probably requires data, and so unique IDs. I don't see how that would work as a BBCode anyway, though.
Made by developers, for developers!
My blog

Post Reply