Search found 45 matches

by Elsensee
Sat Aug 08, 2015 1:13 am
Forum: [3.x] Discussion
Topic: Google Ads enforces EU cookie legislation and demands we notify the visitor
Replies: 14
Views: 39575

Re: Google Ads enforces EU cookie legislation and demands we notify the visitor

However, some admins are worried about bloat and unnecessary ACP options, which is why I suggested officially-supported extensions. I presume that officially-supported extensions (as opposed to regular extensions) get the same scrutiny as core code, so they would be safe. [...] Of course, this depe...
by Elsensee
Fri Aug 07, 2015 1:28 am
Forum: [3.x] Discussion
Topic: Google Ads enforces EU cookie legislation and demands we notify the visitor
Replies: 14
Views: 39575

Re: Google Ads enforces EU cookie legislation and demands we notify the visitor

Things like these (that are required for legal reasons) belong to the core IMHO. Extensions are there for admins who want to add new functions or to improve functions/behaviors. If an administrator decides to use no extensions because he is afraid of the possible vulnerabilities, he should have ever...
by Elsensee
Mon Jul 27, 2015 9:38 pm
Forum: [3.x] Discussion
Topic: Google Ads enforces EU cookie legislation and demands we notify the visitor
Replies: 14
Views: 39575

Re: Google Ads enforces EU cookie legislation and demands we notify the visitor

I think that you could still add a cookie notice to the core with the ability to turn it on/off. It may just be enforced by EU law but it isn't a bad idea worldwide.
by Elsensee
Wed Jun 03, 2015 1:50 pm
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 88590

Re: Asset management

So we allow forum admins to change the js by removing the *.min version. What about updates? Changes in the js would mean a new *.min.js version as well so the custom javascript would be useless until the *.min.js is removed again. I don't want to let the support team deal with tons of questions abo...
by Elsensee
Fri May 29, 2015 12:56 pm
Forum: General Development Discussion
Topic: New rules for pull requests & commits
Replies: 7
Views: 25875

Re: New rules for pull requests & commits

Nicofuma wrote:When using the merge button can we custom the commit message?
I think so, but how does that help? If we're using git blame we don't see the merge commits. And while we can go to the parent commit in GitHub we can't go to the child somehow. :/
by Elsensee
Fri May 29, 2015 10:12 am
Forum: General Development Discussion
Topic: New rules for pull requests & commits
Replies: 7
Views: 25875

Re: New rules for pull requests & commits

naderman wrote:How to figure out in git history which issue was related to a commit
Didn't you said, that the ticket id of the newly created ticket would be added to the PR? If so, then it's easy.

The PR number of a commit is displayed in a commit so you should be able to find the ticket id. :)
by Elsensee
Sat May 16, 2015 9:33 pm
Forum: [3.x] Discussion
Topic: Renaming an existing feature in phpBB 3.1.4
Replies: 23
Views: 29128

Re: Renaming an existing feature in phpBB 3.1.4

We are not renaming a feature only because other software has named a similiar feature different. ;) But the term "softdelete" is totally valid. I mean.. you're clicking on the "delete" button when softdeleting, aren't you? ;D Hide/unhide would be a "good" name for some...
by Elsensee
Sat May 16, 2015 12:32 pm
Forum: [3.x] Event Requests
Topic: [PHP] core.move_topics and core.delete_topics
Replies: 4
Views: 24641

Re: [PHP] core.move_topics and core.delete_topics

You don't have to create a topic or post in this forum anymore. :)
Just create a ticket and you'll be fine. :)
by Elsensee
Wed May 06, 2015 2:41 pm
Forum: [3.x] Discussion
Topic: Specify multiple smilie codes, for the same smilie
Replies: 11
Views: 13587

Re: Specify multiple smilie codes, for the same smilie

I still can't see the reason for this change. Why can't you just use one smiley code?
by Elsensee
Tue May 05, 2015 9:13 pm
Forum: [3.0/Olympus] Discussion
Topic: Releasing 3.0.14
Replies: 5
Views: 51261

Re: Releasing 3.0.14

There are no language and style changes. (Well, except the version update in the style config file ;) )