Search found 115 matches

by AmigoJack
Thu Nov 06, 2014 12:18 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Extensions
Replies: 113
Views: 283710

Re: [RFC|Merged] Extensions

extract($phpbb_dispatcher->trigger_event('core.viewforum_get_topic_data', compact($vars))); This call is sub-optimal, and I don't know why this call pattern has evolved. Cons:
extract() is slower than i.e. foreach() $$var= $value
extract() might fail when incorrect data is passed. Documentation ...
by AmigoJack
Thu Feb 20, 2014 12:33 pm
Forum: [3.x][Archive] RFCs
Topic: Better Magic URLs
Replies: 26
Views: 35990

Re: Better Magic URLs

I was always against applying titles when making URIs clickable for the most obvious reason: it gives away information one may not have had access to otherwise.


Applying titles once per post submit:
Advantages :
Low performance hit - URIs have to be fetched only once and could directly be ...
by AmigoJack
Thu Feb 20, 2014 10:42 am
Forum: [3.x][Archive] RFCs
Topic: [GSoC] Search Backend Refactoring
Replies: 18
Views: 42336

Re: [GSoC] Search Backend Refactoring

Since [RFC|Accepted] Search Backend Refactoring has been superseded by this one and there aren't any status updates I'd like to remember that a search abstraction would lead to huge improvements of searching:
PMs
topic/forum lists in
subscriptions
bookmarks
MCP Every of those lists can be ...
by AmigoJack
Thu Oct 17, 2013 7:19 pm
Forum: [3.x] Tickets Discussion
Topic: [RFC] Ability to @mention specific users in posts
Replies: 241
Views: 498515

Re: [RFC] Ability to @mention specific users in posts

Re: Hashtag MOD is a tryout to implement #keyword auto-links. The biggest problem is to isolate plaintext from instructions (speak: HTML/CSS/JS...).

A problem with @ could be the very same: ftp://user:[email protected] is a legal link and some CSS in the post can also have @page . And while you can ...
by AmigoJack
Wed Aug 21, 2013 2:32 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Automatic move banned members for the banned group
Replies: 11
Views: 16780

Re: [RFC] Automatic move banned members for the banned group

Since I've rendered this already:

I created a new phpbb_users.old_primary_group column which gets updated just before the new primary group " Banned users " is assigned. Once we unban users which then removes them from the banned group the value from that column is used to set the group from the ...
by AmigoJack
Sat Jul 06, 2013 7:08 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Switch to PHP timezone handling
Replies: 95
Views: 198470

Re: [RFC|Merged] Switch to PHP timezone handling

Is the JS already done? Otherwise jsTimezoneDetect looks promising for getting Olson names.
by AmigoJack
Sun Oct 28, 2012 7:43 pm
Forum: [3.0/Olympus] Discussion
Topic: Autoselect the textarea to write in
Replies: 34
Views: 69830

Re: Autoselect the textarea to write in

Pony99CA wrote:This may be obvious
No, never thought of that one. But I 1+ all suggestions. Especially the last one would prevent TOFUing.
by AmigoJack
Sun Oct 28, 2012 6:14 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Reinventing the ACP
Replies: 9
Views: 29502

Re: [RFC] Reinventing the ACP

finding information You said more than you may have thought of: the ACP should have a keyword search, so you're able to find what you want by typing in an appropriate caption. However, since captions are language-specific we have to find a connection to the language files (definitions) and back ...
by AmigoJack
Sat Oct 06, 2012 7:08 am
Forum: [3.x] Rejected RFCs
Topic: [RFC] Password hashing in own class
Replies: 7
Views: 28386

Re: [RFC] Password hashing in own class

It's too similar because password checking (and hence hashing) should become a part of the authentication plugin anyway. Currently it's hardcoded to the phpBB core and custom auth plugins can't reach/realize everything they should. In a perfect world all of the default authentication stuff resides ...
by AmigoJack
Fri Oct 05, 2012 11:07 am
Forum: [3.0/Olympus] Discussion
Topic: Use vertical resize on the textarea.
Replies: 46
Views: 201947

Re: Use vertical resize on the textarea.

TheKiller wrote:the grabber
The add-on Textarea resizer for Opera works even better and on every site. Works on a JS base flawlessly on all TEXTAREA, IMG, INPUT, SELECT, IFRAME, VIDEO, CANVAS and OBJECT elements, not just on one specific, for over 18 months already.