Search found 166 matches

by Marc
Mon Nov 19, 2012 12:11 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Accepted] Avatar improvements, Gravatar
Replies: 15
Views: 37299

Re: [RFC|Accepted] Avatar improvements, Gravatar

I'd like to note that I have opened a WIP pull request at github: https://github.com/phpbb/phpbb3/pull/1100
by Marc
Thu Nov 08, 2012 12:28 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Breadcrumb microdata
Replies: 26
Views: 52307

Re: [RFC] Breadcrumb microdata

Looks good to me.

+1
by Marc
Tue Nov 06, 2012 10:54 am
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] <base>
Replies: 16
Views: 16706

Re: [RFC] <base>

I'd say at least -1 for phpBB 3.1.
by Marc
Tue Nov 06, 2012 10:53 am
Forum: [3.x] Discussion
Topic: Integrating automatic image resizing
Replies: 61
Views: 49677

Re: Integrating automatic image resizing

@Marc ... Personally, I don't like that code. There are parts that are too repeated. For example, the $() is executed excessively. There's no need to execute that function that many times. You could simplify the browser's work with very simple changes to that code. IMO, if you reduce the use of the...
by Marc
Sun Nov 04, 2012 10:08 pm
Forum: [3.x] Discussion
Topic: Integrating automatic image resizing
Replies: 61
Views: 49677

Re: Integrating automatic image resizing

Adding this would be as easy as adding this or a similar code and executing it in $(document).ready() : /** * Image resizer */ function resize_images() { var maxWidth = $('div.content').innerWidth() - 30; // resize the attached images $('img', 'dt.attach-image').each(function(i){ // check the width ...
by Marc
Sun Nov 04, 2012 9:22 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] <base>
Replies: 16
Views: 16706

Re: [RFC] <base>

How would this impact on the use of append_sid() (not sure if it's still that in 3.1)?
by Marc
Wed Oct 24, 2012 7:39 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Make ext/ directory
Replies: 18
Views: 17161

Re: [RFC] Make ext/ directory

+1 for the idea
DavidIQ wrote:Or the usual blank index.htm file.
+1
by Marc
Sun Oct 21, 2012 8:01 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Twig as our template engine
Replies: 90
Views: 84873

Re: [RFC] Twig as our template engine

I'd say go for twig.
by Marc
Fri Aug 10, 2012 3:11 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Make icons clickable
Replies: 27
Views: 30311

Re: [RFC] Make icons clickable

I mean the read/unread indicator. ;)
by Marc
Fri Aug 10, 2012 2:49 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Make icons clickable
Replies: 27
Views: 30311

[RFC] Make icons clickable

I've already heard from several people using phpBB that they are having trouble with clicking on the the navbar links. While there are icons, only the text link is clickable, which seems to be confusing users. This also applies to the forum and topic icons. Changing the navbar icons to being clickab...