Search found 289 matches

by Ger
Tue Feb 13, 2018 8:49 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 7416

Re: Why does Travis fail?

Well, I've just done it through the Github browser interface.

I've closed my original PR and deleted my fork. Now I've recreated the change and did another PR. Fingers crossed... :P
by Ger
Mon Feb 12, 2018 11:28 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 7416

Re: Why does Travis fail?

Than can you please explain me how to fix this commit message?

I've made an error indeed while creating the commit but fixed it within a minute or so.
by Ger
Mon Feb 12, 2018 9:05 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 7416

Why does Travis fail?

https://travis-ci.org/phpbb/phpbb/jobs/340383829 I've made a simple PR adding 3 simple lines to an event (3 of them comment). The Travis test fails here: 0.51s$ sh -c "set -x;if [ '$NOTESTS' = '1' -a '$TRAVIS_PULL_REQUEST' != 'false' ]; then git remote set-branches --add origin $TRAVIS_BRANCH && git...
by Ger
Thu Oct 12, 2017 8:08 am
Forum: [3.x] Discussion
Topic: function make_clickable_callback
Replies: 7
Views: 8764

Re: function make_clickable_callback

There was also an extension that dealt with external urls but i ve removed it and i cant figure out which it was. I believe it was Primehalo's "PrimeLinks" extension But i cant figure out how to configure it to do that. Its configured in the listener file. No ACP settings. I couldn't figure out how...
by Ger
Thu Jul 27, 2017 3:13 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor
Replies: 460
Views: 404956

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

It's about the post that's quoted, isn't it? That already has a post date in a timezone, as stated in my previous post. It's passed as $user->format_date($row['post_time']) so it uses the timezone and formatting for the posting user. When you also pass the unix timestamp to the message parser, you'r...
by Ger
Thu Jul 27, 2017 1:43 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor
Replies: 460
Views: 404956

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

The quote tag has many features. It has the user, the post id, the time of posting and the user id from where the post came from. unfortunately, though, some are dynamic... Maybe too dynamic (just an expression. Not really). See here: https://github.com/phpbb/phpbb/blob/master/phpBB/phpbb/textforma...
by Ger
Thu Jul 27, 2017 7:37 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor
Replies: 460
Views: 404956

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

So basically you have everything working except for the quote-tag? If that's the case, can you elaborate on the exact issue you run into? It's probably somewhere in this topic, but I can't seem to find it...
Is it just about indenting nested quotes?
by Ger
Thu Jun 08, 2017 1:34 pm
Forum: [3.x] Discussion
Topic: Extensionalize phpBB
Replies: 19
Views: 15423

Re: Extensionalize phpBB

If that's the case you might just as well lock this topic.
by Ger
Thu Jun 08, 2017 12:08 pm
Forum: [3.x] Discussion
Topic: PM System
Replies: 10
Views: 12820

Re: PM System

First of, I get that recent events in the UK might cause some to question ways of getting ahead of things. Even forums themselves (not just he PM system) can be used by potential terrorists. Per se, even that is unmonitored. What you're asking for here is basically what the NSA and GCHQ have been d...
by Ger
Thu Jun 08, 2017 12:00 pm
Forum: [3.x] Discussion
Topic: Extensionalize phpBB
Replies: 19
Views: 15423

Re: Extensionalize phpBB

I like this idea actually. Now of course the choices of which function should be extensionalized and which shouldn't is open to debate. But something that's mentioned quite often are the COPPA functionality (USA only) and birthdays. Those two aren't really biggies I think so you might consider movin...