Search found 1063 matches

by callumacrae
Wed Jun 03, 2015 11:55 am
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

only works if you're literally just doing minification and concatenation. doesn't work if you want stuff like autoprefixer, also doesn't work if you want the build process to pull in libraries from npm instead of including the jquery source in the repo.
by callumacrae
Wed Jun 03, 2015 11:15 am
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

It should 100% be required to commit the compiled code to the repo, we don't want people who don't want to make front-end changes to have to install and run gulp. I never suggested otherwise—it's not a great solution, but it's the best we have.
by callumacrae
Wed Jun 03, 2015 11:02 am
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

Yeah, thats basically what I was going to do If we would have minified versions of assets in the repo, wouldn't that be possible, that I do some harmless thing in the "normal" version of the JS and add some malware install code into the minified one? (That's might be a non-issue, just asking) It can...
by callumacrae
Wed Jun 03, 2015 9:06 am
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

The sourcemaps issue is still not resolved. It's resolved for CSS by a LESS parser which only supports an old subset of LESS, but it isn't resolved for JS. EDIT: I was wrong, the sourcemaps issue is resolved! It's resolved by using Gulp. Gzipping is usually done by the server or CDN. There are also ...
by callumacrae
Wed Jun 03, 2015 9:04 am
Forum: General Development Discussion
Topic: JS linting
Replies: 12
Views: 9833

Re: JS linting

It's not a requirement anyway

feel free to send a pr
by callumacrae
Tue Jun 02, 2015 3:31 pm
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

I guess it would be on deployment, as minified versions are hard to review. Source maps ! They're supported by every JavaScript minifier ever, and none of the PHP ones. I meant the GitHub repo, but luckily I don't have to review anything, therefore I don't really care. As I said, I think adding som...
by callumacrae
Tue Jun 02, 2015 2:50 pm
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

CHItA wrote:I guess it would be on deployment, as minified versions are hard to review.
Source maps!

They're supported by every JavaScript minifier ever, and none of the PHP ones.
by callumacrae
Tue Jun 02, 2015 9:12 am
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

We have an opportunity to literally halve the load time of phpBB, and doing these things really would help.

Most of your points are invalid. Obviously I don't want to make it trickier for users to modify their sites.
by callumacrae
Mon Jun 01, 2015 5:54 pm
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

JShrink would probably work, but it doesn't look like it does very much. It doesn't even change variables names , which is a pretty essential feature for a minifier. Same with minify . CssMin doesn't have tests, and so just isn't an option. Why do you think front-end development tools written by non...
by callumacrae
Mon Jun 01, 2015 4:44 pm
Forum: [3.x] Discussion
Topic: Asset management
Replies: 50
Views: 33000

Re: Asset management

I made a piece of code in less than 1h that does just that in pure PHP with only what comes in default PHP. I tested and it works as expected. Fair enough. https://github.com/peteboere/css-crush/ & compatible with composer. It also has some other bits and whistles you may think interesting. I'm not...