Search found 201 matches

by Erik Frèrejean
Sun Jun 17, 2012 10:53 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Permissions for Board Statistics
Replies: 14
Views: 9381

Re: [RFC] Permissions for Board Statistics

if a board is new, then is is new. If a board is not very active, then it is not very active. ;) ^ that Hiding those statistics won't make a board look any busier, if you browse the board for a couple of minutes you'll notice whether the board is busy or not no matter whether there are statistics (...
by Erik Frèrejean
Fri Jun 15, 2012 9:42 pm
Forum: [3.0/Olympus] Discussion
Topic: phpBB 3.0.11 Release Candidate 1 published
Replies: 41
Views: 51475

Re: phpBB 3.0.11 Release Candidate 1 published

RC1 breaks backward compatibility. ticket
by Erik Frèrejean
Fri Jun 15, 2012 4:21 pm
Forum: [3.x] Rejected Event Requests
Topic: [RFC|Rejected] database constants hook
Replies: 2
Views: 10079

Re: [RFC] database constants hook

Why not simply define them in your extension file when it gets loaded? I honestly can't remember the last time I added a database constant to that file.
by Erik Frèrejean
Fri Jun 15, 2012 10:47 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Automated Updating
Replies: 31
Views: 45865

Re: [RFC] Automated Updating

How are update problems being handled?
How are the files going to be written?
How is the update going to be verified whether it was successful?

I'm -1 on background updates, the system could automatically prepare the update, but the actual update should always be triggered by the user.
by Erik Frèrejean
Tue Jun 12, 2012 10:20 pm
Forum: [3.x] Discussion
Topic: automod should probably be shipped with phpbb by default. ..
Replies: 17
Views: 13842

Re: automod should probably be shipped with phpbb by default

Before this process will been started you should complete the core first. Then you and we will have less things to migrate and an effort immediately for the core and for the phpBB using community, too. That is what we are doing right now... but we cannot know each and every event location that an e...
by Erik Frèrejean
Tue Jun 12, 2012 5:46 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Human Readable URLs
Replies: 132
Views: 191282

Re: [RFC] Human Readable URLs

What he means is there needs to be a way to disable the new URL structure to fallback on the current, e.g. viewtopic.php?t=14 instead of /t14-my-topic/ Obviously without mod_rewrite, trying to access the latter will not work, but links should be changed at runtime based on the URL setting that woul...
by Erik Frèrejean
Tue Jun 12, 2012 4:03 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Human Readable URLs
Replies: 132
Views: 191282

Re: [RFC] Human Readable URLs

I support http://area51.phpbb.com/phpBB/viewtopic.php?p=240415#p240415, half-solutions I'd rather not do. The problem with that is that it requires that the server supports mod_rewrite. It should be made in such a way that it gracefully falls back to the current behavior if you don't have mod_rewri...
by Erik Frèrejean
Mon Jun 11, 2012 3:53 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC] Coding guidelines - Comma on left
Replies: 10
Views: 11802

Re: [RFC|Accepted] Coding Guideline Modifications

+1

I'm actually starting to utilise this style more and more on private projects. Especially in the "and" case the resulting query is a lot easier to read when just glazing over it.
by Erik Frèrejean
Wed Jun 06, 2012 8:15 pm
Forum: [3.x] Discussion
Topic: Events on $template->assign*()
Replies: 10
Views: 6607

Re: Events on $template->assign*()

If you made the event "core.assign_vars" then your listener would be run on each and every assign_vars() method call, when really you want it to only run, for instance, on viewtopic. You still need uniquely-named events for the listeners to subscribe to. EDIT: An idea is to add a another (optional)...
by Erik Frèrejean
Wed Jun 06, 2012 8:13 pm
Forum: [3.x] Discussion
Topic: Events on $template->assign*()
Replies: 10
Views: 6607

Re: Events on $template->assign*()

Okay, so from phpbb_template class, here is an untested implementation for assign_vars:     /**     * Assign key variable pairs from an array     *     * @param array $vararray A hash of variable name => value pairs     * @param string $event_name The name of the event that has access to this assig...