Search found 201 matches

by Erik Frèrejean
Wed Jun 27, 2012 3:10 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] Revert all of ajax in 3.1
Replies: 25
Views: 22835

Re: [RFC] Revert all of ajax in 3.1

t_backoff wrote:not to mention it's still broken.
Are there tickets for those "still" broken? If there are then those issues will be resolved, if not it is hard to expect them to be solved at any point ;)
by Erik Frèrejean
Wed Jun 27, 2012 2:36 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Error, Success & Confirm Class
Replies: 20
Views: 18791

Re: [RFC] Error, Success & Confirm Class

Unknown Bliss wrote:We also have general errors and debug errors. General Errors are used for DB, template, cache and module problems. Debug errors are used for undefined variables and more.
phpBB doesn't actually has debug errors of itself as E_USER_NOTICE are mapped to a fatal error as well.
by Erik Frèrejean
Wed Jun 27, 2012 2:28 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] Revert all of ajax in 3.1
Replies: 25
Views: 22835

Re: [RFC] Revert all of ajax in 3.1

A better solution rather then just nuking this would be to fix up the issues for 3.1, and create a new RFC which is aimed to improve/rewrite parts of the current codebase for 3.2. Software can evolve over time and I believe that this is a case that can evolve quite a bit.
by Erik Frèrejean
Wed Jun 27, 2012 11:28 am
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] Revert all of ajax in 3.1
Replies: 25
Views: 22835

Re: [RFC] Revert all of ajax in 3.1

naderman wrote:That's really not a reason to add any new code lacking documentation.
Though neither a reason to remove already added code, especially as it is hard to expect that anyone will jump in to redo this based upon the way this iteration was handled.
by Erik Frèrejean
Tue Jun 26, 2012 10:29 am
Forum: [3.x] Discussion
Topic: Keep search query when search returns no results
Replies: 22
Views: 14211

Re: Keep search query when search returns no results

Looks to me like the question is if the user messes around with the query string what should the result be: What should be the correct thing to do in case user tries to go to a result page which doesn't exist by changing start = parameter in the link, an error like - "This Search Result Page is not...
by Erik Frèrejean
Tue Jun 26, 2012 9:56 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Coding guidelines: var keyword in js per line
Replies: 62
Views: 35199

Re: [RFC] Coding guidelines: var keyword in js per line

Why don't you give a real argument against this proposal rather then "examples" which either don't have anything to do with the subject or that reflect on something that is already phased out? As far as I'm concerned there is really no hurt, you just have to type 3 additional characters rather than ...
by Erik Frèrejean
Tue Jun 26, 2012 9:38 am
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] Revert all of ajax in 3.1
Replies: 25
Views: 22835

Re: [RFC] Revert all of ajax in 3.1

I can't say that I'm a fan of the current implementation (or for what it is worth the whole AJAX thing at all) , and indeed at the documentation side it also lacks a lot. But it has been merged so it is up to standard never got reviewed properly in the first case then the standards should be reviewe...
by Erik Frèrejean
Mon Jun 25, 2012 7:49 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Coding guidelines: var keyword in js per line
Replies: 62
Views: 35199

Re: [RFC] Coding guidelines: var keyword in js per line

What I wouldn't be against is the change suggested at the end of the article: var foo, bar; foo = 1; bar = 2; That really doesn't help a lot, the first line still changes for no reason. That last example shows completely different behavior, that speaks of the difference whether a variable gets an a...
by Erik Frèrejean
Mon Jun 25, 2012 6:54 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Coding guidelines: var keyword in js per line
Replies: 62
Views: 35199

Re: [RFC] Coding guidelines: var keyword in js per line

Kinda surprised that this isn't already the case.
by Erik Frèrejean
Mon Jun 25, 2012 5:58 pm
Forum: [3.x] Discussion
Topic: Normal user stickied thread
Replies: 9
Views: 7976

Re: Normal user stickied thread

-1 for the forum-list. Yes bookmarks and subscriptions should be easier to access but they shouldn't be right in your face every time. Mostly you bookmark something for future reference but you ain't going to look at those topic every time you visit the board (exceptions left aside) . A link straigh...