Search found 737 matches

by nickvergessen
Sun Dec 14, 2014 9:36 pm
Forum: [3.x] Discussion
Topic: Commit messages and CRLF
Replies: 7
Views: 9488

Re: Commit messages and CRLF

I create the PRs always via GitHubs website and I'm also in windows.

As long as the commit messages themselves are fine, nothing breaks from it.
by nickvergessen
Sun Dec 14, 2014 9:07 pm
Forum: General Development Discussion
Topic: Why user input should not be denied by dev team?
Replies: 3
Views: 11607

Re: Why user input should not be denied by dev team?

developer11 wrote:Without any reason.......Its simply not fair.
If you have any such case, feel free to ask another developer for a second view on the PR/discussion.
But in most of the cases, there are reasons and these reasons mostly will lead every developer to the same result.
by nickvergessen
Mon Dec 08, 2014 9:22 pm
Forum: [3.x] Discussion
Topic: Releasing 3.1.3
Replies: 32
Views: 68954

Re: Releasing 3.1.3

Just to make sure you get this right.
It's an estimated date not a release date. We plan to release on that date,
but if a critical bug comes up or real-life happens it might get moved 1-x week(s) in any direction.
by nickvergessen
Sat Dec 06, 2014 12:22 pm
Forum: [3.x] Discussion
Topic: Releasing 3.1.3
Replies: 32
Views: 68954

Releasing 3.1.3

Todo List for 3.1.3 Estimated release date: Jan 24, 2015 Freeze date: Jan 02, 2015 - Afterwards only critical blockers Make sure phpBB/docs/AUTHORS is up to date ✔ Make sure Contributors have their ranks ✔ Make sure all reports in the security tracker are closed or invalid ✔ Go through Issues fixed...
by nickvergessen
Tue Dec 02, 2014 1:55 pm
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 154180

Re: Template engine changes to allow for structure flexibility

The question is, do we even want multi-inheritance, from my dev perspective I'd say no. If you inherit from a stlye that does something odd, just overwrite it again. There is no need for having 2 inheritance parents. And as for custom structure, just make a good default one? You can structure your f...
by nickvergessen
Tue Dec 02, 2014 10:52 am
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 154180

Re: Template engine changes to allow for structure flexibility

They still need to be updated with all the fixes and "breaking" it, just makes it more obvious that the style needs to be updated. Also if you create such a huge list, it is just a nightmare when creating patches that need a new template file and requires a rebase when another PR added a f...
by nickvergessen
Sun Nov 30, 2014 9:24 pm
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 154180

Re: Template engine changes to allow for structure flexibility

I think you have to realize there are two distinct issues being discussed here. (1) The current organization and naming of files in prosilver (2) Adding a layer to allow any style to use arbitrary structure and file names We all agree that (1) needs to be changed. So let's just reorganize and renam...
by nickvergessen
Tue Nov 18, 2014 12:05 pm
Forum: General Development Discussion
Topic: Teams for developing 3.1 and 3.2
Replies: 3
Views: 6450

Re: Moving FAQ to controllers

Meis2M wrote:+1 for that.

i dont know wen development team start the phpBB 3.2

may two group can develop phpBB.
Group 1: working on phpBB 3.1.x
Group 2: working on phpBB 3.2.x
We will just continue like we did with 3.0 and 3.1
One team to develop them all :geek:
by nickvergessen
Mon Nov 17, 2014 10:03 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: Moving FAQ to controllers
Replies: 4
Views: 25616

Moving FAQ to controllers

While trying to make it easier to translate the FAQs, I'm removing the strange array we use there and switch to normal language strings. As this already changes most of the content, we might aswell just move the FAQs to controllers. Now there are multiple questions: Which routes should be used? I wo...