Development Discussion Board

Hmmmm, well that may cause issues. Wonder how the CDB will handle that, eg

There are significant performance improvements within the notification system.

As many of my extensions use styling I am not sure on how to make the extension work on both 3.1 and 3.2 and use the new styling without using a ton of switches for checking phpBB version or writing additional template ...

I am not sure why your commits are failing. I don't use github to make commits, I use smartgit and it works well.

https://github.com/phpbb/phpbb/pull/4298

DavidIQ wrote: Tue Apr 19, 2016 6:55 pm Actually he didn't have that line before and it was still failing which is why the line is there now.

What are you using to do your commits?

Actually he didn't have PHPBB3-xxx in any of his prior commits which is why they were failing.

Look at the commits I did here and compare them to yours. They are different and you didn't follow what I said needed to be done.

I am following all what posted here, my last commit though
https://github.com/phpbb/phpbb/pull/4297
reports the same error as per the picture I attached here ...

Look at the commits I did here and compare them to yours. They are different and you didn't follow what I said needed to be done.

BTW, the [ticket/xxx] needs to be the very first item in the commit message.

Your second commit is failing because it is lacking the [ticket/nnn] part at the front of the commit message. If you look at each commit I linked you to will see, eg this

[ticket/14051] Replace sql array of viewforum sort topics function …

PHPBB3-14051

and

[ticket/14051] Fix whitespace ...

In each of your commits you need to do the formatting of, eg


[ticket/14596] Deny the installation of Ascraeus under PHP7

PHPBB3-14596

with the only difference being the terminology of what the commit is for.

For example

https://github.com/phpbb/phpbb/pull/4238

You also should be referencing ...

Seems we have a "clash of the titans" thing going on.

We _suggest_ for extension developers to use releases on github and include the vendor in case it is needed

phpBB's GitHub repository is intended for development and contribution...not distribution.

I _suggest_ that all on the team get on ...