Search found 494 matches

by igorw
Fri Aug 03, 2012 8:37 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Dependency Injection Container
Replies: 17
Views: 13128

[RFC|Merged] Dependency Injection Container

Since we started using Dependency Injection we have lots of decoupled classes that can be unit tested. That's great. However, assembling these classes is a pain, as you can see by looking at common.php. There's a lot of boilerplate needed. Worse, this is duplicated across common.php, download/file.p...
by igorw
Fri Jul 13, 2012 9:30 pm
Forum: [3.x] Discussion
Topic: Why PHP take more CPU time than MySQL ?
Replies: 18
Views: 10286

Re: Why PHP take more CPU time than MySQL ?

bantu wrote:Upgrading to the latest stable PHP branch (PHP 5.3 at this time)
You mean PHP 5.4? ;-)
by igorw
Wed Jun 27, 2012 2:04 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] Revert all of ajax in 3.1
Replies: 25
Views: 13879

Re: [RFC] Revert all of ajax in 3.1

I was mostly in charge of finishing up the pull request and the docs in the wiki . There have been quite a lot of different issues discussed here. But I feel like some things are missing from the discussion. Before I comment on what I think we should or should not do, I'd like to hear some answers t...
by igorw
Sun Apr 08, 2012 9:01 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Template tag to include JS files
Replies: 39
Views: 25519

Re: [RFC|Merged] Template tag to include JS files

This does not work for assets though, right?
by igorw
Fri Apr 06, 2012 1:20 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Require Subject on *all* posts
Replies: 20
Views: 12011

Re: [RFC] Require Subject on *all* posts

IMO the subject needlessly clutters all of the posts and should be removed.
Oleg wrote:Post subject may be useful when topic subject changes. Examples:
It would be nice to have some inline note when this happens. I've seen that implemented in a few places, for example on phpBB.de.
by igorw
Wed Apr 04, 2012 6:11 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Use composer.json for styles and track phpBB version
Replies: 13
Views: 10649

Re: [RFC] Separate style and phpBB versions in style.cfg

IMO it makes sense for phpBB styles to specify the target phpBB version. It doesn't have to be a hard requirement, since styles will mostly work after an update, but it should warn the admin that he may want to update his style to one targeting the latest phpBB. I don't really care what format we us...
by igorw
Wed Apr 04, 2012 4:44 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] Holy Grail ajax_api.php
Replies: 2
Views: 3018

Re: [RFC] Holy Grail ajax_api.php

I think this is a bad idea. It makes no sense to duplicate controller logic into a separate file just so we can output it differently. The approach of returning JSON for AJAX requests in the controllers makes way more sense imo.
by igorw
Sun Apr 01, 2012 10:32 am
Forum: [3.x][Archive] RFCs
Topic: Private message notifications
Replies: 23
Views: 13701

Re: [RFC] Private message notifications

No confirm boxes please. A notification should never block what the user is doing right now.