Development Discussion Board

Since we started using Dependency Injection we have lots of decoupled classes that can be unit tested. That's great. However, assembling these classes is a pain, as you can see by looking at common.php. There's a lot of boilerplate needed. Worse, this is duplicated across common.php, download/file ...

Done: PR #904.

bantu wrote:Upgrading to the latest stable PHP branch (PHP 5.3 at this time)

You mean PHP 5.4?

I was mostly in charge of finishing up the pull request and the docs in the wiki .

There have been quite a lot of different issues discussed here. But I feel like some things are missing from the discussion. Before I comment on what I think we should or should not do, I'd like to hear some answers ...

Not as in not yet.

This does not work for assets though, right?

IMO the subject needlessly clutters all of the posts and should be removed.

Oleg wrote:Post subject may be useful when topic subject changes. Examples:

It would be nice to have some inline note when this happens. I've seen that implemented in a few places, for example on phpBB.de.

IMO it makes sense for phpBB styles to specify the target phpBB version. It doesn't have to be a hard requirement, since styles will mostly work after an update, but it should warn the admin that he may want to update his style to one targeting the latest phpBB.

I don't really care what format we ...

I think this is a bad idea. It makes no sense to duplicate controller logic into a separate file just so we can output it differently. The approach of returning JSON for AJAX requests in the controllers makes way more sense imo.

No confirm boxes please. A notification should never block what the user is doing right now.