Search found 760 matches

by 3Di
Thu Jul 22, 2021 5:02 am
Forum: [3.x] Discussion
Topic: html validation errors
Replies: 8
Views: 25033

Re: html validation errors

The first thing that comes to my mind is how the validator can access UCP/ACP/MCP as it is not authorised. :roll: The second thing is that if you don't know how to fix it, you could open a ticket for every single problem in the tracker and let the developers decide whether or not to intervene. The t...
by 3Di
Thu Jul 22, 2021 4:03 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

...It’s not difficult and I do not want a discussion to have to exists. It just ends up being nessecary to point out all the issues “patches” cause as no one wants to touch the html. So being yourself the leader, the master of the html etc... do it yourself and we all will be happy. It is your duty...
by 3Di
Thu Jul 22, 2021 3:56 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

These little things add up to the mess we have now. Nope, they fix that actually. The mess has been made from a squashed commit of you to be honest, where also that extra CSS span rule has been added by you. is desired for 4.0 which we have time to fix If we were to quantify time by comparing it to...
by 3Di
Thu Jul 22, 2021 3:02 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

The main problem is that you are keeping the span Which is there in both 3.2 and 3.3. :ugeek: 2021-07-22 04_58_48-.png Not to mention that if you compare the images from 3.3 and 4.0 you can easily see what I am talking about, not only the foramentioned misalignment but also the increased size of th...
by 3Di
Thu Jul 22, 2021 12:24 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

When I did the original overhaul we opted to remove or cancel out line heights for labels. which means that the line-heights should match the font-size... Well, I have already provided the right solution for this 4.0 prosilver to match the 3.2 and 3.3 ones. https://github.com/phpbb/phpbb/pull/6235#...
by 3Di
Thu Jun 17, 2021 10:54 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

Mannix_ wrote: Thu Jun 17, 2021 10:29 am don't know why it was changed for 4.0 tho.
Sure @hanakin got an answer for you. What I know is what I see ATM. :)
by 3Di
Thu Jun 17, 2021 9:17 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

Mannix_ wrote: Thu Jun 17, 2021 6:29 am Seems like the misalignment comes from the line-height property
3Di wrote: Wed Jun 16, 2021 5:25 am That could be easily fixed including them into a SPAN and assigning a CSS rule to them, like the others.
While your code seems to work I think is not the right way to deal with that, just my opinion that could be wrong. :)
by 3Di
Wed Jun 16, 2021 5:25 am
Forum: [4.x] Discussion
Topic: misalignment on index and viewforum
Replies: 44
Views: 155672

Re: misalignment on index and viewforum

That could be easily fixed including them into a SPAN and assigning a CSS rule to them, like the others.
Not sure if it will be accepted due to some discussion about a new style or the likes, therefore I am not spending time on this.
by 3Di
Thu Jun 03, 2021 11:24 am
Forum: [4.x] Discussion
Topic: clone_post out of the box
Replies: 12
Views: 40980

Re: clone_post out of the box

We have said enough and the data confirms the trend to the detriment of useless discussions. As I said, there is an IDEA and the tracker is available to anyone who "has the time and the inclination" to request a new feature. Amen. 😴 I personally am more inclined to do facts than to argue u...
by 3Di
Thu Jun 03, 2021 7:28 am
Forum: [4.x] Discussion
Topic: clone_post out of the box
Replies: 12
Views: 40980

Re: clone_post out of the box

There is already an idea where you posted and your opinion it was quite the same of us https://www.phpbb.com/community/viewtopic.php?p=15658881#p15658881 This has been discussed already. Clone Post (Not: topic) While I do consider it a useful feature, it's truly a niche feature and a simple text cop...