Development Discussion Board

One thing i can say for sure... we won't adjust every trigger_error() instance.

The proof of principle works and I have attached the modified posting.php to this post. As you can see with some minor changes phpBB3 can have a clean exit. (you will also need to comment out the exit statement in /includes/function.php exit hook).


I do not think we will comment it out there ...

The return; is working for you on all points "it is needed"? (Haven't investigated yet where it would be needed)

I do not think we have that many occurrences of this. The modules can just return (theoretically).

Thanks for the reply. Even when I change the exit statement to "return true;" (which is what essentially the hook would do). the problems still persist with the double pages and the SQL error. Therefore I don't think that adding an exit hook will help.


Adding the hook only makes sure you are ...

Add a hook for the exit_handler() to be able to continue your softwares operation.

What benefit would a project wide standard on commit messages have? :? I’m genuinely curious because to me, a commit message is nothing more than a very simple summary of the commit unless it was a security or bug fix, in which case it would simply be #xxxx


it helps those who want to identify ...

this commit message has zero value. it doesn't tell us if this commit fixed a bug, added a feature or changed a behavior, let alone more specific details like "what was the bug", "what is the feature", "what behavior changed, from what to what, and how to test it".


ideally, a comment would only ...

i'm not saying that all the commit messages in phpbb repo are useless. however, because it seems that you never agreed on a standard, there is a wide variety. "dumdidum", "meh" or "Let's try to keep the lid on the jar" may have some entertainment value, but it tends to fade with time, and these ...

This will solve itself once we upgrade the repository to version 1.5 which support merge tracking.