Search found 107 matches

by Michaelo
Thu Sep 22, 2011 6:23 pm
Forum: [3.x] Discussion
Topic: 3.1 Status
Replies: 26
Views: 34968

Re: 3.1 Status

Possibly premature but is there any discussion in relation to 3.1.x testing?
Mike
by Michaelo
Thu Feb 03, 2011 8:26 pm
Forum: [3.0/Olympus] Styling
Topic: Templating ... a simple guide
Replies: 164
Views: 245468

Re: Templating ... a simple guide

Don't know which portal you are relating to but it should work fine in functions.php
by Michaelo
Mon Jan 10, 2011 6:47 am
Forum: [3.x] Rejected Event Requests
Topic: [RFC|Rejected] hook_template_snippet
Replies: 8
Views: 22111

Re: [RFC] hook_template_snippet : Injecting into the templa

This should not require a specific hook... An assign_block_vars hook should deal with adding content no matter where it is called from... For example, the following would work for all instances:  hook_assign_block_vars('page', 'location', 'array_name'); Where the page would be the current phpbb page...
by Michaelo
Sun Jan 09, 2011 6:50 pm
Forum: [3.x] Rejected Event Requests
Topic: [RFC] hook assign_block_vars
Replies: 5
Views: 14448

Re: [RFC] hook assign_block_vars

Consider the following... (viewtopic.php code ref: Check sticky/announcement time limit) Simplified version, assume core code: if ($topic_data['topic_type'] == POST_STICKY) { ... some code including an sql query ... } A mod edit would result in: if ($topic_data['topic_type'] == POST_STICKY || $topic...
by Michaelo
Fri Jan 07, 2011 12:22 am
Forum: [3.x] Rejected Event Requests
Topic: [RFC] hook assign_block_vars
Replies: 5
Views: 14448

Re: [RFC] hook assign_block_vars

I have deleted this and posted in: [3.1/Ascraeus] Hook Location Requests viewtopic.php?f=111&p=218361#p218361
by Michaelo
Tue Jan 04, 2011 11:11 pm
Forum: [3.0/Olympus] Discussion
Topic: Bots and Styles
Replies: 4
Views: 9456

Re: Bots and Styles

Will test on a clean install without mod... mind you we have only seen the error with bots where styles are constantly updated, added /removed... Reported the use of hard coded language instead of language var... Reported the error relating to bots... Have update the code to: if (!$this->theme) { //...
by Michaelo
Mon Jan 03, 2011 5:52 pm
Forum: [3.0/Olympus] Discussion
Topic: Bots and Styles
Replies: 4
Views: 9456

Re: Bots and Styles

As an alternative and without additional code just use:

Code: Select all

		if (!$this->theme)
		{
			//trigger_error('Could not get style data', E_USER_ERROR);
			redirect(build_url('style') .'?style='. $config['default_style']);
		}
by Michaelo
Sun Dec 26, 2010 3:22 pm
Forum: [3.0/Olympus] Discussion
Topic: Bots and Styles
Replies: 4
Views: 9456

Bots and Styles

For the longest time I have noticed the following error in Error log.. A general error occured: General Error » Could not get style data On this (and all other occasions) it relates to bots using a style that has been disabled or deleted... To fix the problem I add the following code to force the de...
by Michaelo
Wed Jul 14, 2010 11:54 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC & Patch][Implemented] Coding Guidelines
Replies: 55
Views: 51788

Re: [RFC & Patch][Implemented] Coding Guidelines

True in relation to manual editing... but assuming the core may require additional elements to be added during normal updating, the comma will still make it easier...
by Michaelo
Mon Jul 12, 2010 1:43 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC & Patch][Implemented] Coding Guidelines
Replies: 55
Views: 51788

Re: [RFC & Patch][Implemented] Coding Guidelines

One other advantage... simplifies search updates...
Always better to use Search > Add, after as opposed to search, in-line find, in-line add after etc... and all for a comma!