Development Discussion Board

Maybe an option saying 'Would you like to Auto-Login After Registration'?

Suggest not to over-complicate this -- if it ends up in displaying more options to the user, or stuffing the ACP with even more options, it doesn't provide much benefit. I think sensible defaults make more sense than trying ...

We need to reduce the number of confirm boxes, however they cannot go entirely because of CSRF. See http://blog.phpbb.com/2009/01/14/fighting-csrf/ In addition there are also things which are irrecoverable and thus the user needs to be sure.
Link hashes for GET requests and Form tokens for POST ...

GravityDK wrote:Wave is being shut down by Google.
I recommend its removed from the Use Cases on Wiki.

Wave was just a product built on top of the protocols Google have released, it doesn't need Wave to work. It's quite an interesting idea and there isn't any harm in it being on the wiki.

We need to reduce the number of confirm boxes, however they cannot go entirely because of CSRF. See http://blog.phpbb.com/2009/01/14/fighting-csrf/ In addition there are also things which are irrecoverable and thus the user needs to be sure.

4.x should be namespaced properly, there shouldn't be any global variables like $user used, and everything should have unique non-conflicting names (prefixed with phpbb_).
4.x actually requires PHP 5.3 which has namespacing support, thus classes and function do _not_ have to be prefixed with phpbb ...

make_clickable -> make_forumpost_clickable
validate_username -> validate_phpbb_username
Prefix the functions with 'phpbb_' rather than renaming them to something that again may conflict with something else.

In my case, it is WordPress. Yes, WordPress is to blame too, but since they have a mature ...

nn- wrote:wc -l is specified in posix (http://www.opengroup.org/onlinepubs/000 ... es/wc.html), use it instead of --lines.

Max line length sounds like it could be replaced with cut.

How would one go about that with cut?

Really liking the look of this, few things I've noticed:

• Some class methods don't have a visibility defined.
• A number of classes are included manually
• The cron_task interface file has another interface in the file

Yes, uploading multiple files without having to reload the page (using AJAX or even just plain JS to add a new file input field) would greatly improve the user experience. For example when uploading a ton of photos.
Further more that little page refresh is confusing for some users.
To me it just a ...

bantu wrote:

nn- wrote:Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools

Good idea. Created ticket http://tracker.phpbb.com/browse/PHPBB3-9777

FYI It's been merged and just needs verifying.