Search found 24 matches

by GanstaZ
Mon Dec 10, 2018 3:54 pm
Forum: [3.x] Discussion
Topic: Twig extensions
Replies: 6
Views: 22263

Re: Twig extensions

Everything is possible. If some functionality is not present (need some tweaks or simplified usage) in phpbb core at the moment and there are no prs on github (if there are some, those may be accepted or declined, only time will tell), that doesn't mean one can't make an extension to add same functi...
by GanstaZ
Thu Dec 06, 2018 3:50 pm
Forum: General Development Discussion
Topic: Renderer class - why these two variables are different
Replies: 5
Views: 29393

Re: Renderer class - why these two variables are different

Just one thing to add about those 2 quotes out of 3, is that thanks to those lines of code, one can connect to events and modify those mixed vars if needed.
by GanstaZ
Thu Dec 06, 2018 1:20 am
Forum: [3.x] Discussion
Topic: Twig extensions
Replies: 6
Views: 22263

Re: Twig extensions

Not exactly, just some random projects i have seen on github. Haven't seen many phpbb extensions that add functionality or simplicity through twig extension/s, but i know that some have tried to use(are using)/create twig extensions. I made one twig extension for one of my phpbb extensions just to l...
by GanstaZ
Wed Dec 05, 2018 8:49 pm
Forum: [3.x] Discussion
Topic: Twig extensions
Replies: 6
Views: 22263

Re: Twig extensions

Can't see any downsides, maybe only 1 if service will be heavily overloaded, but something like this can be solved. A lot of projects i have seen, use and develop new twig extensions just for the same purpose (to make life easier).
by GanstaZ
Wed Aug 01, 2018 2:03 pm
Forum: [4.x] Style Development
Topic: Outlining a New Theme
Replies: 7
Views: 64431

Re: Outlining a New Theme

If i understand it correctly, it is based/default on the framework that is located in hanakin github repo?
by GanstaZ
Sun Jul 22, 2018 9:03 pm
Forum: [4.x] Discussion
Topic: Name of the new style
Replies: 45
Views: 257093

Re: Name of the new style

Base/default.. smell is the same, but i think you are right about base, it describes the whole system and by that it also points to default.
by GanstaZ
Mon Jul 16, 2018 3:03 pm
Forum: [4.x] Discussion
Topic: Name of the new style
Replies: 45
Views: 257093

Re: Name of the new style

I agree with David about default as style name. There are some examples in this forum and seems that those are based on prosilver colors.
by GanstaZ
Tue May 22, 2018 1:41 pm
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 294426

Re: [NEW THEME] 4. JS frameworks & approach

I like the new theme framework, seems that it will be easy to use. Looking at examples in git repo, twig inheritance & blocks (something like this is needed) will be used with it.
by GanstaZ
Fri May 18, 2018 1:27 pm
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 294426

Re: [NEW THEME] 4. JS frameworks & approach

If only changes are based on twig inheritance & some changes in html based on new theme, then it should be fast/easy. If i understand it correctly, then developing/maintaining styles should be easier with new theme.
by GanstaZ
Tue May 08, 2018 2:53 pm
Forum: [3.x] Tickets Discussion
Topic: Support for Emojis
Replies: 66
Views: 290776

Re: Support for Emojis

Why not add attribute link (at least for now, if there will be a switch to noto or whatever, it can be changed/removed later) that was mentioned in Use of EmojiOne Icons requires attribution link in the footer?