Search found 66 matches

by mrgoldy
Sun May 05, 2019 10:10 pm
Forum: [3.x] Discussion
Topic: "Normal reasons" for FORM_INVALID which now also apply to login forms.
Replies: 4
Views: 9517

Re: "Normal reasons" for FORM_INVALID which now apply to login forms.

Haven't looked into this issue, also not with 3.2.6 But for your specific question on the !empty() . All variables retrieved through $config['setting'] are returned as strings. All booleans stored in the config table are set to '1' ( true ) or '0' ( false ). !empty('1'); returns true !empty('0'); re...
by mrgoldy
Sat May 04, 2019 3:16 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.7-RC1 released
Replies: 10
Views: 15482

Re: phpBB 3.2.7-RC1 released

A missing event dispatcher caused an internal server error when change topic types
Not sure if these release highlights are used for the final package, but if so: changing*
by mrgoldy
Wed Apr 17, 2019 11:13 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 56034

Re: Control panel module system

I know, that's where we are clear on. But how everything is defined. Cause we have three things: - Routes (eg. /admin/index ) that have to be defined - Controllers (eg. phpbb.admin.controller ) that have to be defined - Lists for the *CP Menu (eg. General, Index, Settings, Board settings) that has t...
by mrgoldy
Wed Apr 17, 2019 12:11 pm
Forum: [3.x] Discussion
Topic: OAuth system
Replies: 1
Views: 6049

OAuth system

Currently there are a few issues with the OAuth system and limited possibilities extending it. This has various reasons, but most of them look quite 'easily' fixable, atleast, from the surface. Perhaps I'll retract this statement once I dive into adjusting the code. Uncaught exceptions In the UCP yo...
by mrgoldy
Wed Apr 17, 2019 11:34 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 56034

Re: Control panel module system

Well, I am stuck with this. All options I have proposed thusfar have been 'rejected' or refuted (lack of better words), all with good reasons. However, this does mean that I am out of ideas on possible approaches. I am still willing to take this on, but I would need an actual example/set up of how i...
by mrgoldy
Tue Apr 02, 2019 5:49 pm
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 40
Views: 72825

Re: Ideas. Standard Style Improvements.

I do have to say that I like infinite scroll and hate it at the same time. It reminds me of browsers' history list. How I often navigate through forums is scroll, click on a topic / last post link, read it and then "Back". With these infinite scrolls, you end up at the top again and have to find whe...
by mrgoldy
Tue Mar 05, 2019 11:59 am
Forum: [3.x] Discussion
Topic: LOGIN API FOR EXTERNAL USAGE
Replies: 3
Views: 7406

Re: LOGIN API FOR EXTERNAL USAGE

A REST API is already listed as a GSoC Idea . However, I do believe it is also considered outside the scope of the GSoC project (correct me if I am wrong), so not sure when we will be seeing it. Alternatively, perhaps it's possible that you create your own extension that handles the part you're requ...
by mrgoldy
Mon Feb 25, 2019 2:32 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 56034

Re: Control panel module system

Bit stating the obvious here, but I think we can agree on the fact that we're all leaning towards the following structure: Each control panel page (module) will have its own route. Each control panel route will have its own controller. Each control panel will have its own navigation declared with se...
by mrgoldy
Sat Feb 23, 2019 10:47 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 56034

Re: Control panel module system

Okay, let's post an update. There was a valid point made that with a yml approach, it might be possible to completely cache it. While the services are cached, the order is not. So that together with the fact it's rather hard to make a water-proof before/after ordered collection (not to mention with ...
by mrgoldy
Sat Feb 23, 2019 6:22 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 56034

Re: Control panel module system

And about the approach/thought proposed by CHItA. I've been looking into it and thinking about it some more. This would mean we would have to register each menu item in a yml file, and if it's a menu category, create a service collection for it aswell. Example: services: phpbb.acp.collection: class:...