Search found 72 matches

by P_I
Fri Feb 17, 2017 10:14 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

Thanks for your patience and advice. I've now installed commit hooks.
by P_I
Fri Feb 17, 2017 10:05 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

Still confused. I've done the steps as indicated. They seem to have successfully completed but I'm not seeing them updated on github.

FWIW, I'm working on the command line in Linux (CentOS 7).

Code: Select all

$ git --version
git version 1.8.3.1
by P_I
Fri Feb 17, 2017 9:51 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

Thanks again. Please bear with me so I get it correct. I believe the steps become git rebase --interactive 'ac88815^' which gives me pick ac88815 [3.1.x] Add PHP version to Board statistics pick 29fc038 [ticket/15097] Add PHP version to Board statistics # Rebase b567c6e..29fc038 onto b567c6e # # Com...
by P_I
Fri Feb 17, 2017 9:34 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

Understood and still learning. I just don't understand how to edit and change it. When I click on the commit (https://github.com/phpbb/phpbb/pull/470 ... a85497605) I cannot find an edit/change button. Am I missing something?
by P_I
Fri Feb 17, 2017 9:26 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

I think I've fixed it. I made a second commit to improve a variable name. I would appreciate if you could double-check my work once again. Thanks.
by P_I
Fri Feb 17, 2017 9:10 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

I think I've followed all the steps correct and we're now at https://github.com/phpbb/phpbb/pull/4705 and I added it to https://tracker.phpbb.com/browse/PHPBB3-15097.

Am I done? What's next?
by P_I
Fri Feb 17, 2017 8:43 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

I thought of that, but there's conditional code around Board version and Orphaned attachments that I didn't want to disturb.
by P_I
Fri Feb 17, 2017 8:33 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

Re: PHPBB3-15097 - Board statistics page should show PHP version

D'oh.
While I have your attention, here's my proposed new Board statistics section showing the PHP version.
PHPBB3-15097 fix.PNG
My concern is the table now contains an odd number of entries. Is that OK or should the empty row/column contain a &nbsp?
by P_I
Fri Feb 17, 2017 8:25 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41798

PHPBB3-15097 - Board statistics page should show PHP version

New contributor here who needs some guidance. I created the above ticket and I'd like to make my first contribution to fix phpBB 8-) I've previously only used git to clone repositories for use, not for making any code changes. I'm following the process outlined in Git — phpBB 3.1.x documentation and...
by P_I
Fri Feb 03, 2017 2:59 pm
Forum: General Development Discussion
Topic: Forum structure here needs an update?
Replies: 1
Views: 5021

Forum structure here needs an update?

I could find any guidance where to post this, so here goes. The powers that be might want to look at the forum structure here. After all, phpBB 3.0 is EOL yet back here you see Stable Branch: phpBB "Olympus" 3.0. Stable != EOL.