Search found 72 matches

by P_I
Wed Feb 22, 2017 4:27 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] New Search Feature For Private Messages
Replies: 8
Views: 16173

Re: [RFC] New Search Feature For Private Messages

Completely agree that this should be in the core of phpBB.
by P_I
Sun Feb 19, 2017 8:35 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

Thanks again David. I'll close and reopen.

Update: All checks have passed, again.
by P_I
Sun Feb 19, 2017 8:09 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

Now I'm totally confused. Checked in new code and https://travis-ci.org/phpbb/phpbb/builds/203214390 passed. Then I inadvertently hit the wrong button and closed https://github.com/phpbb/phpbb/pull/4705. I subsequently reopened it and now the same code errored in https://travis-ci.org/phpbb/phpbb/bu...
by P_I
Sun Feb 19, 2017 5:38 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

Time for a functional question. Currently someone with access to ACP but without acl_a_board permission cannot see the phpBB version information, yet they can see the Database server information. I suspect that's unintended. In my next update, I plan to allow anyone with access to ACP to all the Ins...
by P_I
Sun Feb 19, 2017 3:58 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

Two more newbie questions if you don't mind. First, adm/style/acp_main.html contains a number of condition checks such as <!-- IF S_VERSIONCHECK --> . I've read through Tutorial.Template syntax but cannot find anything that helps me understand how to test the various conditions. Some are obvious bas...
by P_I
Sun Feb 19, 2017 2:41 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

I've worked a bit further on this update, separating out the 'Installed software' from the 'Board statistics'. PHPBB3-15097 fix, v2.PNG The concept is borrowed from Version - MediaWiki . Does this improve the ACP main page and potentially reduce the number of questions about what versions of softwar...
by P_I
Sat Feb 18, 2017 4:57 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

I presume my part of the process is now complete and it's up to someone else to review/approve the pull request and decide if/when this gets included in a phpBB release, i.e. 3.1.11 and/or 3.2.1.

Is there anything more for me to do?
by P_I
Sat Feb 18, 2017 12:51 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

Got in done. Passed all tests. Learned a lot in the process that I can apply going forward.
by P_I
Fri Feb 17, 2017 10:35 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15097 - Board statistics page should show PHP version
Replies: 32
Views: 41655

Re: PHPBB3-15097 - Board statistics page should show PHP version

Wow, what a learning experience. I think I've got the issues resolved. Will wait to see what travis-ci.org reports.

@DavidIQ. 👍 👍 for sticking with me and helping.