Development Discussion Board

Two more newbie questions if you don't mind. First, adm/style/acp_main.html contains a number of condition checks such as <!-- IF S_VERSIONCHECK --> . I've read through Tutorial.Template syntax but cannot find anything that helps me understand how to test the various conditions. Some are obvious bas...

I've worked a bit further on this update, separating out the 'Installed software' from the 'Board statistics'. PHPBB3-15097 fix, v2.PNG The concept is borrowed from Version - MediaWiki . Does this improve the ACP main page and potentially reduce the number of questions about what versions of softwar...

That was my plan.

I presume my part of the process is now complete and it's up to someone else to review/approve the pull request and decide if/when this gets included in a phpBB release, i.e. 3.1.11 and/or 3.2.1.

Is there anything more for me to do?

Got in done. Passed all tests. Learned a lot in the process that I can apply going forward.

Wow, what a learning experience. I think I've got the issues resolved. Will wait to see what travis-ci.org reports.

@DavidIQ. for sticking with me and helping.

Thanks for your patience and advice. I've now installed commit hooks.

Still confused. I've done the steps as indicated. They seem to have successfully completed but I'm not seeing them updated on github.

FWIW, I'm working on the command line in Linux (CentOS 7).

Thanks again. Please bear with me so I get it correct. I believe the steps become git rebase --interactive 'ac88815^' which gives me pick ac88815 [3.1.x] Add PHP version to Board statistics pick 29fc038 [ticket/15097] Add PHP version to Board statistics # Rebase b567c6e..29fc038 onto b567c6e # # Com...

Understood and still learning. I just don't understand how to edit and change it. When I click on the commit (https://github.com/phpbb/phpbb/pull/470 ... a85497605) I cannot find an edit/change button. Am I missing something?