Development Discussion Board

any/everyone is responsible for the changes... best way I have found to test them is in your browser change the class on the body from ltr to rtl, then on the html element change the dir to rtl as well. you will have to manually add the bidi.css file to your header...
Thanks, that's very useful ...

hanakin wrote: Thu Feb 23, 2017 6:44 pm 411 the new version of FA includes both quote-left and quote-right icons

Thanks. I caught that and used quote-right for RTL as it was already using quote_rtl.gif.

I cannot find any guidelines on what to do with the RTL case. Are there coding guidelines for RTL in templates and/or CSS?

As I try to come up to speed on contributing to the project, there remain a few mysteries. This is one of them.

I think I've found the code in bidi.css and can follow the ...

this is better handled via a base64 svg in the css than using font-awsome. but yes there are issues with the bbcode somewhere https://area51.phpbb.com/phpBB/viewtopic.php?f=126&t=50486

Thanks. Still haven't solved why bbcode.html isn't being used, but you've given me the necessary clues about ...

This one seemed simple to me. Change styles/prosilver/template/bbcode.html and change the lines containing quote_username_open and quote_open to add the font awesome icon syntax and remove the css entry that provides quote.gif.

But I must be missing something, because no matter what changes to ...

Completely agree that this should be in the core of phpBB.

Thanks again David. I'll close and reopen.

Update: All checks have passed, again.

Now I'm totally confused. Checked in new code and https://travis-ci.org/phpbb/phpbb/builds/203214390 passed.

Then I inadvertently hit the wrong button and closed https://github.com/phpbb/phpbb/pull/4705. I subsequently reopened it and now the same code errored in https://travis-ci.org/phpbb/phpbb ...

Time for a functional question. Currently someone with access to ACP but without acl_a_board permission cannot see the phpBB version information, yet they can see the Database server information. I suspect that's unintended.

In my next update, I plan to allow anyone with access to ACP to all the ...

Two more newbie questions if you don't mind.

First, adm/style/acp_main.html contains a number of condition checks such as <!-- IF S_VERSIONCHECK --> . I've read through Tutorial.Template syntax but cannot find anything that helps me understand how to test the various conditions. Some are obvious ...