Search found 45 matches

by rfdy
Fri Jun 20, 2014 2:12 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Allow Twig Extensions
Replies: 3
Views: 6309

Re: [RFC] Allow Twig Extensions

We write twig extensions to make doing things in the template easier, think of them as super fancy macros. There are many cases where we need to call a custom twig function to insert special content. (ie. {{ display_special_block() }}). Without a twig extension you're pretty much blindly calling a f...
by rfdy
Fri Jun 20, 2014 2:05 pm
Forum: [3.x] Discussion
Topic: Advanced template engine functionnality (blocks)
Replies: 10
Views: 10729

Re: Advanced template engine functionnality (blocks)

There are a few threads (and jiras) about doing this, ie. making full use of Twig's power.

+1
by rfdy
Thu Jun 19, 2014 4:03 pm
Forum: [3.1/Ascraeus] Merged Event Requests
Topic: [PHP] core.viewforum_get_forum_data
Replies: 2
Views: 11141

[PHP] core.viewforum_get_forum_data

There needs to be a way to alter the template data (ideally before it is assigned) for the forum details in viewforum.php . Currently there is an event core.viewforum_get_topic_data which only allows editing of the sql, it should also send $forum_data so that an extension can change some of the temp...
by rfdy
Thu Jun 19, 2014 2:53 pm
Forum: [3.x] Discussion
Topic: how to extract variables out of $template?
Replies: 9
Views: 12201

Re: how to extract variables out of $template?

Just tried this out and it didn't work.

print_r($template->_tpldata); results in: Undefined property: phpbb/template/twig/twig::$_tpldata

Any other suggestions?
by rfdy
Wed Jun 18, 2014 7:36 pm
Forum: [3.x] Discussion
Topic: how to extract variables out of $template?
Replies: 9
Views: 12201

Re: how to extract variables out of $template?

Thanks! I'll try it soon.
by rfdy
Wed Jun 18, 2014 7:23 pm
Forum: [3.x] Discussion
Topic: how to extract variables out of $template?
Replies: 9
Views: 12201

how to extract variables out of $template?

Is it at all possible to extract blocks out of $template, so they can be manipulated by the extension before being reassigned? Trying to override the breadcrumbs functionality, but that function sets template variables directly. This kind of stuff happens in a few places and is very difficult to cod...
by rfdy
Wed Jun 18, 2014 7:20 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Allow Twig Extensions
Replies: 3
Views: 6309

[RFC] Allow Twig Extensions

Current the Twig_Environment is hidden away in \phpbb\template\twig\twig, this makes it difficult to enable debugging in Twig, as the debug extension is not added by default (this can easily be done by checking for the DEBUG constant). The real problem is that it doesn't not appear to be possible fo...
by rfdy
Tue Jun 10, 2014 5:31 pm
Forum: [3.x] Discussion
Topic: Set Meta keywords and description
Replies: 16
Views: 13344

Re: Set Meta keywords and description

It also appears that google has begun penalizing (or at least down ranking) user-created content, so the description on topic view pages might not actually do that much (especially since they could be rich in text). Meta descriptions on the index and forum view pages are the most important as those ...
by rfdy
Tue Jun 10, 2014 1:41 pm
Forum: [3.x] Discussion
Topic: Set Meta keywords and description
Replies: 16
Views: 13344

Re: Set Meta keywords and description

most search engines (or at least the ones that matter, ie. google) ignore keywords. description on the other hand is rather important as it's what google displays under the link in the results and should be descriptive and unique.

there might already be a topic about this somewhere.
by rfdy
Tue Jun 10, 2014 1:33 pm
Forum: [3.x] Discussion
Topic: cron cli with extensions
Replies: 5
Views: 4659

Re: cron cli with extensions

A jira for this has been created here: https://tracker.phpbb.com/browse/PHPBB3-12686

I wonder if it's related to https://tracker.phpbb.com/browse/PHPBB3-12685