Search found 45 matches

by rfdy
Fri Jul 11, 2014 6:26 pm
Forum: [3.x] Event Requests
Topic: [PHP] core.pagination_generate_page_link
Replies: 9
Views: 13497

Re: [PHP] core.pagination_generate_page_link

We've had a similar issue (implemented slugs/SEO and additional filter arguments in the URL that need to be preserved). We also replaced the "start" URL argument with a "page" one, to be compatible with our old forum. This is how we did it: Implement your own "pagination" service in your extension t...
by rfdy
Fri Jul 11, 2014 6:16 pm
Forum: [3.x] Discussion
Topic: LIKE posts feature added in phpBB 3.1
Replies: 40
Views: 73210

Re: LIKE posts feature added in phpBB 3.1

making this core in 3.2 would be great. this is the ideal functionality for us: - ability to enable/disable feature on a forum by forum basis - implement user permission (to allow some users to like, default to all roles except read-only) - option somewhere to enable/disable down votes - display vot...
by rfdy
Tue Jul 08, 2014 7:54 pm
Forum: [3.x] Discussion
Topic: LIKE posts feature added in phpBB 3.1
Replies: 40
Views: 73210

Re: LIKE posts feature added in phpBB 3.1

Just a heads up, but we've actually developed such extension. We're migrating from VB, so this is a feature we really needed. It can be enabled on a forum by forum basis; implements a custom specific user permission, and allows basic un/thanking functionality with stats. It will be released fairly s...
by rfdy
Mon Jun 30, 2014 1:28 pm
Forum: [3.1/Ascraeus] Merged Event Requests
Topic: core.posting_modify_template_vars correction
Replies: 18
Views: 32601

Re: core.posting_modify_template_vars correction

This thread isn't actually relevant anymore since the changes we requested were eventually made some time after beta 3.
by rfdy
Fri Jun 27, 2014 10:33 pm
Forum: [3.1/Ascraeus] Merged Event Requests
Topic: core.posting_modify_template_vars correction
Replies: 18
Views: 32601

Re: core.posting_modify_template_vars correction

bump, would be very interested to hear opinions on last post
by rfdy
Mon Jun 23, 2014 8:10 pm
Forum: [3.x] Discussion
Topic: Is phpbb_forums.forum_parents no longer being used?
Replies: 1
Views: 2078

Is phpbb_forums.forum_parents no longer being used?

A while ago I noticed forum_parents field was being populated fine, so I wrote some code to make use of it when available, but recently (tried a few different nightlies) that this field is no longer being populated with any data. I tried creating a new category, forum, and moving forums around and t...
by rfdy
Fri Jun 20, 2014 5:22 pm
Forum: [3.x] Discussion
Topic: Advanced template engine functionnality (blocks)
Replies: 10
Views: 10718

Re: Advanced template engine functionnality (blocks)

Sure, keep the syntax for 3.1, but 3.2 really should try to move things forwards.

It shouldn't be difficult to write a 3.0 to twig conversion tool that style authors can use.
by rfdy
Fri Jun 20, 2014 5:12 pm
Forum: [3.x] Discussion
Topic: how to extract variables out of $template?
Replies: 9
Views: 12167

Re: how to extract variables out of $template?

We did exactly that. And was strongly rejected. The event included "modify template" in its name, yet the array was assigned to the template before the event was called. Our suggestion to fix that was denied claiming we should use "global $template". We found a way around our initial request, but ot...
by rfdy
Fri Jun 20, 2014 3:55 pm
Forum: [3.x] Discussion
Topic: how to extract variables out of $template?
Replies: 9
Views: 12167

Re: how to extract variables out of $template?

Using alter block with the breadcrumbs for example is cumbersome. It was much easier to just destroy the entire "navlinks" block and recreate it.

Mentioned this before, but: events should really be called with template array data before it is assigned to the template.
by rfdy
Fri Jun 20, 2014 3:53 pm
Forum: [3.x] Discussion
Topic: Advanced template engine functionnality (blocks)
Replies: 10
Views: 10718

Re: Advanced template engine functionnality (blocks)

Not sure why you'd want to preserve phpbb's ancient template syntax. Modern IDEs support twig, and many projects are moving to twig (drupal, et al), so the more standard syntax it is kept the better.