Development Discussion Board

In your PR I see you're using a check to see whether the message was originally parsed using our old bbcode engine or your new one. For reference, this is the check EXreaction is talking about . What it does is test whether a text starts with <pt or <rt . s9e\TextFormatter generates an XML represen...

Alright, I've changed the cache dir to point to tests/tmp/ and I'm typehinting the cache driver interface, as that's what other services seem to do. I don't intend to touch the legacy code, so no worries there. I've just pushed a big update that implements the new text formatting as a service. Or ra...

Alright, I have a few questions for which I couldn't find a definite answer. It's about tests: I'm dumping compiled templates to cache/ -- can I hardcode the .php extension or do I have to use %core.php_ext%/$phpEx ? the normal code saves files to cache/ -- where should those files be saved during t...

I've created a WIP pull request . It might be noisy because I try to commit regularly and I often push so that Travis can keep an eye on it. I'm currently looking into how phpBB's tests work, especially wrt database. Also, I'm not sure where which tests should go so for the time being I put them whe...

You could consider it a superset in a way. It would supersede it. Also, I omitted it but while this RFC is limited to just fixing bugs and having a more robust parser, the long term benefit is that you get new features for almost free. Extended custom BBCodes syntax , better XSS detection, extended ...

Ticket: PHPBB3-11768 PR: #3461 -------------------- https://travis-ci.org/s9e/phpbb.png?branch=ticket/11768 • Branch @ GitHub • Pull request • Old pull request Synopsis s9e\TextFormatter , a text formatting library that supports BBCodes and most other features found in forums, implemented as plugin...

As far as I know, foreign keys only slow down queries in MySQL. Write queries, specifically.

Foreign keys are only constraints put on top of indices. They don't improve read queries and they have a cost on write queries.

Preface Earlier this year , I have announced in this forum the text formatting library I've been working on, s9e\TextFormatter . Since then, brunoais has agreed to take on the difficult task of cleaning up phpBB's current message parser and prepare to replace it with s9e\TextFormatter. In the meant...

Ideally I'd prefer having the deepest levels automatically removed when the user clicks the "Quote" button, eventually with a non-intrusive warning displayed on the posting page indicating that the deepest level of quote was removed. Most commonly, people "overquote" because they...

If your JavaScript preview contains a <script> element it'll get executed when you display it. Same for <img onerror="..."/> and other XSS vectors. It's not terribly useful though, because you need to trick somebody into either manually entering the XSS vector in the message box, or someho...