Search found 379 matches

by JoshyPHP
Fri Aug 16, 2013 7:56 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

The next item on my TODO list is fetching BBCode templates from styles, which I'll start soon. Unless instructed otherwise, I'll reuse the same routines as bbcode::bbcode_cache_init() except with objects from the service container instead of globals. I can help explain how the styles system is setup...
by JoshyPHP
Thu Aug 15, 2013 9:44 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

A bit of a daily update: today, I made polls work . This doesn't sound like much, but it took more time than I'm comfortable admitting. parse_message (the class in message_parser.php) would be a prime candidate to be refactored into something less complicated, especially once the old text formatting...
by JoshyPHP
Wed Aug 14, 2013 2:48 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

What does this have to do with the text formatter? Shouldn't that be a new topic? When I originally posted that message, the new code would silently ignore invalid stuff and even if it did generate errors, there was no interface for the parse_message class to collect errors from the parser. I poste...
by JoshyPHP
Tue Aug 13, 2013 7:30 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Get rid of JavaScript in HTML code
Replies: 14
Views: 15978

Re: [RFC] Get rid of JavaScript in HTML code

Twig can escape new lines in attributes, but I don't know how it works with phpBB's templating.
by JoshyPHP
Tue Aug 13, 2013 5:57 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

I'm currently working on posting limits. Here's a breakdown of how the legacy code behave when those limits are exceeded and the default behaviour of the new code. max_*_font_size old: cannot post + error displayed on submit, BBCode silently ignored on preview new: cannot post + error displayed on s...
by JoshyPHP
Tue Aug 13, 2013 12:48 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

In your PR I see you're using a check to see whether the message was originally parsed using our old bbcode engine or your new one. For reference, this is the check EXreaction is talking about . What it does is test whether a text starts with <pt or <rt . s9e\TextFormatter generates an XML represen...
by JoshyPHP
Mon Aug 12, 2013 9:05 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

Alright, I've changed the cache dir to point to tests/tmp/ and I'm typehinting the cache driver interface, as that's what other services seem to do. I don't intend to touch the legacy code, so no worries there. I've just pushed a big update that implements the new text formatting as a service. Or ra...
by JoshyPHP
Fri Aug 09, 2013 10:18 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

Alright, I have a few questions for which I couldn't find a definite answer. It's about tests: I'm dumping compiled templates to cache/ -- can I hardcode the .php extension or do I have to use %core.php_ext%/$phpEx ? the normal code saves files to cache/ -- where should those files be saved during t...
by JoshyPHP
Thu Aug 08, 2013 6:07 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

I've created a WIP pull request . It might be noisy because I try to commit regularly and I often push so that Travis can keep an eye on it. I'm currently looking into how phpBB's tests work, especially wrt database. Also, I'm not sure where which tests should go so for the time being I put them whe...
by JoshyPHP
Tue Aug 06, 2013 3:39 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 251065

Re: [RFC] Integrate s9e\TextFormatter

You could consider it a superset in a way. It would supersede it. Also, I omitted it but while this RFC is limited to just fixing bugs and having a more robust parser, the long term benefit is that you get new features for almost free. Extended custom BBCodes syntax , better XSS detection, extended ...