Development Discussion Board

I should correct myself. When I said "Twig can escape new lines in attributes" what I really meant was "Twig can escape attributes" . Does Twig escape new lines? I've checked with the W3 Validator and it seems that new lines are valid in attribute values. As long as quotes get es...

I'm a bit stuck wrt styles. What's the best way to get a list of all styles? Should I just query the database like style_select() does? And once I have the list of styles, what's the easiest way to get the bbcode.html of each style? I thought that reusing the code from bbcode::bbcode_cache_init() wo...

It doesn't create any HTML file. In short, it goes like this: <special custom BBCode syntax like phpBB's admin panel> :arrow: XSLT :arrow: <internal representation> :arrow: PHP. And here's a near-complete rundown. In phpBB land, phpbb_textformatter_s9e_factory::get_configurator() creates an instance...

My plan right now is to capture all the template fragments from bbcode.html and recompose each BBCode's template using the same syntax as custom BBCodes. For instance, for the BBCode i : i_open + {TEXT} + i_close = <em>{TEXT}</em> . After this, it's exactly the same as a custom BBCode entered in the...

Wrong. The bitfield marks which BBCodes were used in that text out of all the predefined ones. You're talking about a different thing. If you look into bbcode::bbcode_cache_init() and bbcode::bbcode_tpl() you can see how $this->template_bitfield is being used. You might want to use the template eng...

The next item on my TODO list is fetching BBCode templates from styles, which I'll start soon. Unless instructed otherwise, I'll reuse the same routines as bbcode::bbcode_cache_init() except with objects from the service container instead of globals. I can help explain how the styles system is setup...

A bit of a daily update: today, I made polls work . This doesn't sound like much, but it took more time than I'm comfortable admitting. parse_message (the class in message_parser.php) would be a prime candidate to be refactored into something less complicated, especially once the old text formatting...

What does this have to do with the text formatter? Shouldn't that be a new topic? When I originally posted that message, the new code would silently ignore invalid stuff and even if it did generate errors, there was no interface for the parse_message class to collect errors from the parser. I poste...

Twig can escape new lines in attributes, but I don't know how it works with phpBB's templating.

I'm currently working on posting limits. Here's a breakdown of how the legacy code behave when those limits are exceeded and the default behaviour of the new code. max_*_font_size old: cannot post + error displayed on submit, BBCode silently ignored on preview new: cannot post + error displayed on s...