Search found 384 matches

by JoshyPHP
Sat Aug 24, 2013 12:39 am
Forum: [3.x][Archive] RFCs
Topic: Doctrine ORM
Replies: 12
Views: 18940

Re: Doctrine ORM

How long would it take to write a basic model for the main objects used in phpBB? A PoC would surely help people form an opinion or update their old opinion. I haven't used Doctrine since the early 2.0 versions, and back then it lacked some features that made me forgo trying to use it. I haven't had ...
by JoshyPHP
Fri Aug 23, 2013 11:53 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

If there is an easy way the custom bbcode editor can be built so this sort of logic is intuitive to use and easy to understand, then that would be fantastic and I would be very interested in seeing how it could be used.
Ultimately, my goal in generating rules automatically is that nobody would ...
by JoshyPHP
Fri Aug 23, 2013 9:30 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

There are multiple, different arguments here so I'll try to separate them.

First, error messages. Error messages is what programmers want to read. Users, not so much. The problem with error messages is that they immediately break the flow of operation. The user wanted to post a message, but instead ...
by JoshyPHP
Thu Aug 22, 2013 10:02 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

I'm not sure what you mean there, or what your concern is. What do you think would become complex?

Taking PHPBB3-9386 as an example, the difference between the quote breaking bold/italic or the quote being disabled is one option. Either I pass 'closeParent' => array('b', 'i', 'u') as an option when ...
by JoshyPHP
Thu Aug 22, 2013 7:10 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

I've added some basic tests today . One of them (misnested tags) made me realize something (that phpBB uses span elements.) But first, a word about tag rules in s9e\TextFormatter.

s9e\TextFormatter supports a relatively wide array of rules governing tags, such as BBCode tags. Those rules allow ...
by JoshyPHP
Wed Aug 21, 2013 9:59 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

Today's update: I've added support for the attachment BBCode . Once I made sense of how the current code works, I managed to adapt to it with minimum work.

For reference, here's how the legacy routines work:
The user posts [аttachment=0]icon_e_biggrin.gif[/attachment]
It is stored as [аttachment ...
by JoshyPHP
Wed Aug 21, 2013 3:36 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

It determines which default templates are replaced. For instance, the default template for [b] uses <span style="font-weight: bold">. prosilver's template uses <strong>, but since the bit for [b] is not set, it uses the default template instead.
by JoshyPHP
Tue Aug 20, 2013 8:01 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

I assume that styles inherit the whole bbcode.html, not just parts of it right? Do they also inherit the same bbcode_bitfield or can it be different from its parent?

Update: pushed to GitHub . I recurse into each style's parents until I find one that has a bbcode.html file. I don't touch the style ...
by JoshyPHP
Tue Aug 20, 2013 4:29 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

I went with the original plan B: query the database, glob all the styles/*/template/bbcode.html files and recompose BBCode templates based on the fragments. The commit is here. The path to styles/ is configurable. This is what the renderer looks like for prosilver+subsilver.
by JoshyPHP
Mon Aug 19, 2013 4:24 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 447910

Re: [RFC] Integrate s9e\TextFormatter

Actually I do need every bbcode.html file at the same time. All the templates of all the BBCodes of all the styles get cached in the same file.