Search found 384 matches

by JoshyPHP
Mon Sep 02, 2013 3:28 am
Forum: [3.x][Archive] RFCs
Topic: Doctrine ORM
Replies: 12
Views: 18950

Re: Doctrine ORM

As I said, I don't know much about entities and models. What I know is people, and how people always have a slightly different interpretation of everything (see MVC ten years ago.) I had hoped you'd describe what you wanted to do with any level of technical detail rather than rely on extremely vague ...
by JoshyPHP
Sun Sep 01, 2013 1:16 pm
Forum: [3.x][Archive] RFCs
Topic: Doctrine ORM
Replies: 12
Views: 18950

Re: Doctrine ORM

I'll echo Pony99CA's sentiment that it's not immediately obvious what using Doctrine ORM would mean in concrete terms. Here's an example: let's say that I'm rewriting the mod tools and I want to move post #1 from topic #2 in forum #3 to topic #4 in forum #5, what would be the PHP code for doing just ...
by JoshyPHP
Sun Sep 01, 2013 12:39 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

After 4 weeks of development, producing 99 commits totalling 5548 line changes over 61 files and including 157 unit tests, I hereby declare my work on this PR done.

Future PRs should include migrating old posts to the new format, removing the legacy routines, and finally make use of s9e ...
by JoshyPHP
Sat Aug 31, 2013 4:03 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

s9e\TextFormatter logs a warning when a tag is not allowed in context (e.g. quote inside of b.) If you wanted phpBB to display those as errors, you'd need to modify phpbb_textformatter_s9e_parser ::get_errors() and add something like
elseif ($msg === 'Tag is not allowed in this context' && $context ...
by JoshyPHP
Fri Aug 30, 2013 2:18 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

I believe if the admin sets pixel limits on images and somebody tries to post images that are larger, they will get an error.
I can confirm that's how it works. By default there are no limits, but if you set a limit on width or height it will download the image and check its size and potentially ...
by JoshyPHP
Fri Aug 30, 2013 1:20 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

Finally, I have a couple of outstanding matters that I need to address before declaring this PR ready. The first of which is on the first page, it's about whitespace within code tags. s9e\TextFormatter preserves it, and does not really have a mechanism to modify it. The legacy routines do that ...
by JoshyPHP
Fri Aug 30, 2013 12:43 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

I've just committed a big overhaul to the way s9e\TextFormatter automatically generates rules , which makes it possible to individually toggle the "rules generators" and even extend them. Those rules generators cover functionalities that are usually hardcoded within BBCode parsers, such as optional ...
by JoshyPHP
Tue Aug 27, 2013 12:40 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

I'm thinking about loops that could happen in some other cases. I didn't specify, sorry.

It might be theorically possible to create a set of rules that would cause two tags to automatically close each other, and automatically reopen them. When used one after the other, they would indefinitely open ...
by JoshyPHP
Mon Aug 26, 2013 11:21 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

I'm almost done with the TODO list that's on the first page. The last few remaining items are:

Tabs in code blocks are preserved, legacy routines replaces them. Haven't looked into it yet. I'm probably going to post-process the output to replace tabs with the unholy mixture of spaces and &nbsp ...
by JoshyPHP
Sat Aug 24, 2013 6:56 am
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 448156

Re: [RFC] Integrate s9e\TextFormatter

I hate seeing unrendered tags in posts
I too, would love to omit bad tags from the output, but I haven't found a way that works reliably. I believe it's a problem that does not have a definitive solution. I've sunk a lot of time thinking about it while developing the library, and we could ...